Skip to content

Close hostfxr handle, skip creating unnecessary parameters#1982

Merged
liliankasem merged 1 commit intoAzure:mainfrom
elinor-fung:nativeHostSuggestions
Oct 23, 2023
Merged

Close hostfxr handle, skip creating unnecessary parameters#1982
liliankasem merged 1 commit intoAzure:mainfrom
elinor-fung:nativeHostSuggestions

Conversation

@elinor-fung
Copy link
Copy Markdown
Contributor

@elinor-fung elinor-fung commented Oct 23, 2023

  • Call hostfxr_close in AppLoader instead of trying to free the handle
  • Don't create/pass optional hostfxr_initialize_parameters when initializing
  • Use StringMarshalling property on LibraryImport to set marshalling for all strings in the function

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@elinor-fung
Copy link
Copy Markdown
Contributor Author

@kshyju this is some of the suggestions we sent over e-mail for the native host.

cc @vitek-karas

Copy link
Copy Markdown
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @elinor-fung !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants