Close hostfxr handle, skip creating unnecessary parameters#1982
Merged
liliankasem merged 1 commit intoAzure:mainfrom Oct 23, 2023
Merged
Close hostfxr handle, skip creating unnecessary parameters#1982liliankasem merged 1 commit intoAzure:mainfrom
liliankasem merged 1 commit intoAzure:mainfrom
Conversation
Contributor
Author
|
@kshyju this is some of the suggestions we sent over e-mail for the native host. cc @vitek-karas |
kshyju
approved these changes
Oct 23, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hostfxr_closein AppLoader instead of trying to free the handlehostfxr_initialize_parameterswhen initializingStringMarshallingproperty onLibraryImportto set marshalling for all strings in the functionPull request checklist
release_notes.md