Conversation
kshyju
commented
Oct 23, 2023
satvu
approved these changes
Oct 23, 2023
jviau
requested changes
Oct 23, 2023
Contributor
jviau
left a comment
There was a problem hiding this comment.
See comment for using $(TargetName)$(TargetExt)
Member
Author
Yea. Switched to the variable in the latest iteration. Thank you! |
jviau
reviewed
Oct 24, 2023
jviau
reviewed
Oct 24, 2023
Contributor
jviau
left a comment
There was a problem hiding this comment.
I won't block this PR on this, but I think the best approach would be to do something like:
<PropertyGroup>
<_FunctionsTarget>dotnet $(TargetName)$(TargetExt)</_FunctionsTarget>
<_FunctionsTarget Condition="('$(SelfContained)' == 'true' OR '$(PublishAot)' == 'true') AND '%(Identity)' == '$(AppHostIntermediatePath)'">%(None.Link)</_FunctionsTarget>
</PropertyGroup>With that, we can then consolidate all of the different ways to produce worker.config with just a single replacement via _FunctionsTarget
jviau
approved these changes
Nov 13, 2023
4e6fbf9 to
1a18653
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1053
Pull request checklist
release_notes.md