Sending EnableUserCodeException as a capability of native worker #1960
Merged
Sending EnableUserCodeException as a capability of native worker #1960
Conversation
- Improving the exception message for env reload failure. - Version bump to 1.0.2
kshyju
requested review from
brettsam,
fabiocav,
jviau,
liliankasem,
satvu and
surgupta-msft
kshyju
commented
Oct 12, 2023
fabiocav
approved these changes
Oct 12, 2023
brettsam
reviewed
Oct 12, 2023
| <title>Microsoft Azure Functions dotnet-isolated native host</title> | ||
| <tags>dotnet-isolated azure-functions azure</tags> | ||
| <version>1.0.1</version> | ||
| <version>1.0.2</version> |
Member
There was a problem hiding this comment.
Had we released 1.0.1 already?
| Logger.LogTrace("App payload uses an older version of worker package which does not support specialization."); | ||
| responseMessage.FunctionEnvironmentReloadResponse = BuildFailedEnvironmentReloadResponse(new EnvironmentReloadNotSupportedException()); | ||
| Logger.LogTrace("App payload uses an older version of Microsoft.Azure.Functions.Worker SDK which does not support placeholder."); | ||
| var e = new EnvironmentReloadNotSupportedException("This app is not using the latest version of Microsoft.Azure.Functions.Worker SDK and therefore does not leverage all performance optimizations. See https://aka.ms/azure-functions/dotnet/placeholders for more information."); |
Member
There was a problem hiding this comment.
It may not be super-important for this scenario, but there won't be a StackTrace with this without throwing it, will there? You can throw/catch the exception to capture the StackTrace correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnableUserCodeExceptionas a capability of native worker. - this forces host to log it in a way it surfaces user's AI logs.