Service Bus settlement support#1945
Merged
liliankasem merged 18 commits intoAzure:mainfrom Oct 19, 2023
Merged
Conversation
JoshLove-msft
commented
Oct 4, 2023
extensions/Worker.Extensions.ServiceBus/src/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
commented
Oct 4, 2023
extensions/Worker.Extensions.ServiceBus/src/Worker.Extensions.ServiceBus.csproj
Outdated
Show resolved
Hide resolved
Member
Author
|
Still need to add tests/samples |
JoshLove-msft
commented
Oct 4, 2023
jsquire
reviewed
Oct 4, 2023
extensions/Worker.Extensions.ServiceBus/src/Proto/settlement.proto
Outdated
Show resolved
Hide resolved
jviau
reviewed
Oct 4, 2023
extensions/Worker.Extensions.ServiceBus/src/ServiceBusMessageActions.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusMessageActions.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusMessageActions.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusMessageActions.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusMessageActionsConverter.cs
Show resolved
Hide resolved
extensions/Worker.Extensions.ServiceBus/src/Worker.Extensions.ServiceBus.csproj
Outdated
Show resolved
Hide resolved
jviau
reviewed
Oct 6, 2023
extensions/Worker.Extensions.ServiceBus/src/Proto/settlement.proto
Outdated
Show resolved
Hide resolved
jviau
approved these changes
Oct 13, 2023
fabiocav
reviewed
Oct 17, 2023
extensions/Worker.Extensions.ServiceBus/src/ServiceBusMessageActionsConverter.cs
Show resolved
Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusMessageActions.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusMessageActions.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.ServiceBus/src/ServiceBusMessageActions.cs
Outdated
Show resolved
Hide resolved
jviau
reviewed
Oct 17, 2023
extensions/Worker.Extensions.ServiceBus/src/Proto/settlement.proto
Outdated
Show resolved
Hide resolved
liliankasem
reviewed
Oct 18, 2023
extensions/Worker.Extensions.ServiceBus/src/ServiceBusMessageActionsConverter.cs
Show resolved
Hide resolved
Member
|
I think this all looks good - would love to see some tests and samples added |
Member
Author
Added! |
fabiocav
approved these changes
Oct 19, 2023
liliankasem
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1538
Pull request checklist
release_notes.mdAdditional information
Additional PR information