Conversation
Member
Author
brettsam
reviewed
Sep 27, 2023
liliankasem
approved these changes
Sep 27, 2023
… specialization request received and no payload is present.
kshyju
force-pushed
the
shkr/1931_functionsnethost_fail_specialization-when-no-payload
branch
from
16b36ff to
1504dee
Compare
kshyju
deleted the
shkr/1931_functionsnethost_fail_specialization-when-no-payload
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1931
Currently, If we get specialization request without a valid payload present in the
FunctionAppDirectory, our code crashes when trying to load the assembly. This PR updates that code path so that it will send an instance of EnvironmentReloadResponse with "Failure" as the "Status" property value.