Use project namespace for generated code#1930
Merged
Conversation
kshyju
requested review from
aishwaryabh,
brettsam,
fabiocav,
jviau,
liliankasem,
satvu,
soninaren and
surgupta-msft
and removed request for
fabiocav,
jviau and
satvu
brettsam
approved these changes
Sep 27, 2023
jviau
approved these changes
Sep 27, 2023
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-functions-dotnet-worker
that referenced
this pull request
Oct 4, 2023
* Using root namespace for generated types. * release notes * Using "RootNamespace" msbuild property and adding null check * Adding "RootNamespace" to global configs in the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1158
Currently the namespace for generated code is hardcoded as
Microsoft.Azure.Functions.Worker. With this change, we will use the root namespace.RootNamespaceis a prop our project will inherit from the Microsoft.Net.Sdk.props.User can override this by setting the
FunctionsGeneratedCodeNamespacemsbuild property.Fix was made to all source generators.
Pull request checklist
release_notes.mdAdditional information
Additional PR information