Analyzer to detect missing ASP.NET Core integration registration#1917
Analyzer to detect missing ASP.NET Core integration registration#1917surgupta-msft merged 48 commits intomainfrom
Conversation
fabiocav
left a comment
There was a problem hiding this comment.
Haven't reviewed the implementation, but we need to make sure this analyzer is part of the ASP.NET Core integration package.
This reverts commit 226e3b4.
jviau
left a comment
There was a problem hiding this comment.
I think we discussed having this analyzer only trigger if ConfigureFunctionsWorkerDefaults is present and ConfigureFunctionsWebApplication is not. Are we going with that approach or not?
I don't like the idea of having this analyzer trying to warn on the absence of something on IHostBuilder without something extra to indicate this is intended to be a function app and they are not configuring at as we expect.
(Providing a brief summary below about the things we discussed to avoid any confusion) My understanding is we changed error to warning because absence of For this exact thing - this analyzer only trigger if Update - had an offline discussion. I have updated the code with this check. Thanks for catching this. |
Issue describing the changes in this PR
resolves #1902
Pull request checklist
release_notes.mdAdditional information
Additional PR information