[Source Gen] Add diagnostic logs for errors when parsing attribute arguments#1882
Merged
[Source Gen] Add diagnostic logs for errors when parsing attribute arguments#1882
Conversation
satvu
commented
Sep 6, 2023
jviau
approved these changes
Sep 11, 2023
Contributor
jviau
left a comment
jviau
left a comment
There was a problem hiding this comment.
I don't really see any harm in adding a diagnostic message for an edge case. It is better than having it silently no-op. Now if it was more logic than just a diagnostic message I would reconsider - but it isn't.
liliankasem
reviewed
Sep 11, 2023
liliankasem
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1878
Pull request checklist
release_notes.mdAdditional information
Additional PR information