Skip to content

[Source Gen] Parse named args by type correctly#1877

Merged
satvu merged 5 commits intomainfrom
satvu/source-gen-named-arg-type
Aug 31, 2023
Merged

[Source Gen] Parse named args by type correctly#1877
satvu merged 5 commits intomainfrom
satvu/source-gen-named-arg-type

Conversation

@satvu
Copy link
Copy Markdown
Member

@satvu satvu commented Aug 30, 2023

Issue describing the changes in this PR

resolves #1876

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@satvu satvu requested review from fabiocav and kshyju August 30, 2023 22:50
@satvu satvu force-pushed the satvu/source-gen-named-arg-type branch from 6ca0e98 to f07100f Compare August 30, 2023 23:39
@satvu satvu marked this pull request as ready for review August 31, 2023 00:13
@satvu satvu changed the title [Source Gen] Parsed named args by type correctly [Source Gen] Parse named args by type correctly Aug 31, 2023
Copy link
Copy Markdown
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread sdk/release_notes.md Outdated
Co-authored-by: Lilian Kasem <likasem@microsoft.com>
@satvu satvu merged commit b4e4ba8 into main Aug 31, 2023
@satvu satvu deleted the satvu/source-gen-named-arg-type branch August 31, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Source generated metadata provider Enum serialization is not consistent with the default provider

4 participants