Skip to content

Replace RPC worker startup with explicit call#1860

Merged
jviau merged 2 commits intoAzure:mainfrom
jviau:rpc-shading
Aug 28, 2023
Merged

Replace RPC worker startup with explicit call#1860
jviau merged 2 commits intoAzure:mainfrom
jviau:rpc-shading

Conversation

@jviau
Copy link
Copy Markdown
Contributor

@jviau jviau commented Aug 24, 2023

This PR adjusts how worker RPC is configured. Switching from using WorkerExtensionStartup to a method that extensions which wish to use RPC are required to call. This is done to enable dependency shading if it deemed necessary.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@jviau jviau requested a review from fabiocav August 24, 2023 17:46
@jviau jviau merged commit 16748f2 into Azure:main Aug 28, 2023
@jviau jviau deleted the rpc-shading branch August 28, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants