Skip to content

Adding "global::" namespace prefix to avoid namespace conflict inside generated executor#1847

Merged
kshyju merged 2 commits intomainfrom
shkr/global_prefix_namespace
Aug 23, 2023
Merged

Adding "global::" namespace prefix to avoid namespace conflict inside generated executor#1847
kshyju merged 2 commits intomainfrom
shkr/global_prefix_namespace

Conversation

@kshyju
Copy link
Copy Markdown
Member

@kshyju kshyju commented Aug 21, 2023

Fixes #1816

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@jviau
Copy link
Copy Markdown
Contributor

jviau commented Aug 22, 2023

This is an aside to the problem at hand, but I wonder if we should use RootNamespace from the project for this files namespace?

@kshyju
Copy link
Copy Markdown
Member Author

kshyju commented Aug 23, 2023

This is an aside to the problem at hand, but I wonder if we should use RootNamespace from the project for this files namespace?

Yes. some thing we can consider for all src generators. IIRC, I tried that route and found out that root namespace is not always a non null value. Let me see I can go back and check my repro and we can sync on this.

@kshyju kshyju merged commit 86f8186 into main Aug 23, 2023
@kshyju kshyju deleted the shkr/global_prefix_namespace branch August 23, 2023 12:48
@kshyju
Copy link
Copy Markdown
Member Author

kshyju commented Aug 24, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Namespace conflict inside generated executor

3 participants