Adding "global::" namespace prefix to avoid namespace conflict inside generated executor#1847
Merged
Adding "global::" namespace prefix to avoid namespace conflict inside generated executor#1847
Conversation
kshyju
commented
Aug 21, 2023
kshyju
commented
Aug 21, 2023
jviau
approved these changes
Aug 22, 2023
Contributor
|
This is an aside to the problem at hand, but I wonder if we should use |
liliankasem
approved these changes
Aug 22, 2023
Member
Author
Yes. some thing we can consider for all src generators. IIRC, I tried that route and found out that root namespace is not always a non null value. Let me see I can go back and check my repro and we can sync on this. |
Member
Author
|
The fix is released in 1.14.1 https://github.com/Azure/azure-functions-dotnet-worker/releases/tag/sdk-1.14.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1816
Pull request checklist
release_notes.mdAdditional information
Additional PR information