Skip to content

Cleanup extension samples and reset release notes#1814

Merged
liliankasem merged 5 commits intomainfrom
liliankasem/update-samples
Aug 16, 2023
Merged

Cleanup extension samples and reset release notes#1814
liliankasem merged 5 commits intomainfrom
liliankasem/update-samples

Conversation

@liliankasem
Copy link
Copy Markdown
Member

@liliankasem liliankasem commented Aug 10, 2023

Issue describing the changes in this PR

resolves #1805

Removing WorkerExtensionBinding sample and updating the Extension sample project.

Future work: Updated best practice for output without using the output binding

Comment thread samples/Extensions/Blob/BlobFunction.cs Outdated
@liliankasem liliankasem force-pushed the liliankasem/update-samples branch from c592979 to 9e96fd2 Compare August 11, 2023 16:20
@liliankasem liliankasem force-pushed the liliankasem/update-samples branch from 7e48987 to 2064c40 Compare August 15, 2023 21:45
@fabiocav fabiocav requested a review from surgupta-msft August 16, 2023 20:11
Comment thread samples/FunctionApp/FunctionApp.csproj Outdated
@liliankasem liliankasem merged commit e1148b2 into main Aug 16, 2023
@liliankasem liliankasem deleted the liliankasem/update-samples branch August 16, 2023 22:40
Copy link
Copy Markdown
Contributor

@ggailey777 ggailey777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liliankasem just an FYI we were using some of these code examples in our documentation. The hint is that for most of these I added snippet tags to the source code. This caused a break in our Azure documentation build until they removed the snippets from the source .md files.

Adding @mattchenderson for awareness.

@liliankasem
Copy link
Copy Markdown
Member Author

@liliankasem just an FYI we were using some of these code examples in our documentation. The hint is that for most of these I added snippet tags to the source code. This caused a break in our Azure documentation build until they removed the snippets from the source .md files.

Adding @mattchenderson for awareness.

😱 oh no! I didn't realise, thanks for the info - will keep this in mind with future updates. Is there anything we can do to help update the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Converge WorkerBindingSamples into core extension examples

4 participants