-
Notifications
You must be signed in to change notification settings - Fork 204
Support binding to EventData #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
liliankasem
merged 4 commits into
Azure:feature/sdk-type-binding
from
JoshLove-msft:eh-bindings
Jun 13, 2023
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| namespace Microsoft.Azure.Functions.Worker.Extensions.EventHubs | ||
| { | ||
| internal static class Constants | ||
| { | ||
| internal const string BinaryContentType = "application/octet-stream"; | ||
|
|
||
| internal const string BindingSource = "AzureEventHubsEventData"; | ||
| } | ||
| } |
58 changes: 58 additions & 0 deletions
58
extensions/Worker.Extensions.EventHubs/src/EventDataConverter.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| using System; | ||
| using System.Linq; | ||
| using System.Threading.Tasks; | ||
| using Azure.Core.Amqp; | ||
| using Microsoft.Azure.Functions.Worker.Converters; | ||
| using Microsoft.Azure.Functions.Worker.Core; | ||
| using Microsoft.Azure.Functions.Worker.Extensions.Abstractions; | ||
| using Azure.Messaging.EventHubs; | ||
| using Microsoft.Azure.Functions.Worker.Extensions.EventHubs; | ||
|
|
||
| namespace Microsoft.Azure.Functions.Worker | ||
| { | ||
| [SupportsDeferredBinding] | ||
| [SupportedConverterType(typeof(EventData))] | ||
| [SupportedConverterType(typeof(EventData[]))] | ||
| internal class EventDataConverter : IInputConverter | ||
| { | ||
| public ValueTask<ConversionResult> ConvertAsync(ConverterContext context) | ||
| { | ||
| try | ||
| { | ||
| ConversionResult result = context?.Source switch | ||
| { | ||
| ModelBindingData binding => ConversionResult.Success(ConvertToEventData(binding)), | ||
| // Only array collections are currently supported, which matches the behavior of the in-proc extension. | ||
| CollectionModelBindingData collection => ConversionResult.Success(collection.ModelBindingDataArray | ||
| .Select(ConvertToEventData).ToArray()), | ||
| _ => ConversionResult.Unhandled() | ||
| }; | ||
| return new ValueTask<ConversionResult>(result); | ||
| } | ||
| catch (Exception exception) | ||
| { | ||
| return new ValueTask<ConversionResult>(ConversionResult.Failed(exception)); | ||
| } | ||
| } | ||
|
|
||
| private EventData ConvertToEventData(ModelBindingData binding) | ||
| { | ||
| if (binding?.Source is not Constants.BindingSource) | ||
| { | ||
| throw new InvalidOperationException( | ||
| $"Unexpected binding source. Only '{Constants.BindingSource}' is supported."); | ||
| } | ||
|
|
||
| if (binding.ContentType != Constants.BinaryContentType) | ||
| { | ||
| throw new InvalidOperationException( | ||
|
liliankasem marked this conversation as resolved.
|
||
| $"Unexpected content-type. Only '{Constants.BinaryContentType}' is supported."); | ||
| } | ||
|
|
||
| return new EventData(AmqpAnnotatedMessage.FromBytes(binding.Content)); | ||
| } | ||
| } | ||
| } | ||
5 changes: 4 additions & 1 deletion
5
extensions/Worker.Extensions.EventHubs/src/EventHubTriggerAttribute.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
extensions/Worker.Extensions.EventHubs/src/Properties/AssemblyInfo.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| using System.Runtime.CompilerServices; | ||
| using Microsoft.Azure.Functions.Worker.Extensions.Abstractions; | ||
|
|
||
| [assembly: ExtensionInformation("Microsoft.Azure.WebJobs.Extensions.EventHubs", "5.3.0")] | ||
| [assembly: ExtensionInformation("Microsoft.Azure.WebJobs.Extensions.EventHubs", "5.4.0")] | ||
| [assembly: InternalsVisibleTo("Microsoft.Azure.Functions.WorkerExtension.Tests, PublicKey=00240000048000009400000006020000002400005253413100040000010001005148be37ac1d9f58bd40a2e472c9d380d635b6048278f7d47480b08c928858f0f7fe17a6e4ce98da0e7a7f0b8c308aecd9e9b02d7e9680a5b5b75ac7773cec096fbbc64aebd429e77cb5f89a569a79b28e9c76426783f624b6b70327eb37341eb498a2c3918af97c4860db6cdca4732787150841e395a29cfacb959c1fd971c1")] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,12 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
|
|
||
| namespace Microsoft.Azure.Functions.Worker.Extensions.ServiceBus | ||
| { | ||
| public static class Constants | ||
|
liliankasem marked this conversation as resolved.
|
||
| internal static class Constants | ||
| { | ||
| internal const string BinaryContentType = "application/octet-stream"; | ||
|
|
||
| internal const string BindingSource = "AzureServiceBusReceivedMessage"; | ||
| } | ||
| } | ||
25 changes: 0 additions & 25 deletions
25
extensions/Worker.Extensions.ServiceBus/src/ServiceBusExtensionStartup.cs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
samples/WorkerBindingSamples/EventHubs/EventDataSamples.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| // Copyright (c) .NET Foundation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
|
|
||
| using Azure.Messaging.EventHubs; | ||
| using Microsoft.Azure.Functions.Worker; | ||
| using Microsoft.Extensions.Logging; | ||
|
|
||
| namespace SampleApp | ||
| { | ||
| /// <summary> | ||
| /// Samples demonstrating binding to the <see cref="EventData"/> type. | ||
| /// </summary> | ||
| public class EventDataSamples | ||
| { | ||
| private readonly ILogger<EventDataSamples> _logger; | ||
|
|
||
| public EventDataSamples(ILogger<EventDataSamples> logger) | ||
| { | ||
| _logger = logger; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// This function demonstrates binding to a single <see cref="EventData"/>. Note that when doing so, you must also set the | ||
| /// <see cref="EventHubTriggerAttribute.IsBatched"/> property to <value>false</value> as the default value of this property is | ||
| /// <value>true</value>. | ||
| /// </summary> | ||
| [Function(nameof(EventDataFunctions))] | ||
| public void EventDataFunctions( | ||
| [EventHubTrigger("queue", Connection = "EventHubConnection", IsBatched = false)] EventData @event) | ||
| { | ||
| _logger.LogInformation("Event Body: {body}", @event.Body); | ||
| _logger.LogInformation("Event Content-Type: {contentType}", @event.ContentType); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// This function demonstrates binding to an array of <see cref="EventData"/>. | ||
| /// </summary> | ||
| [Function(nameof(EventDataBatchFunction))] | ||
| public void EventDataBatchFunction( | ||
| [EventHubTrigger("queue", Connection = "EventHubConnection")] EventData[] events) | ||
| { | ||
| foreach (EventData @event in events) | ||
| { | ||
| _logger.LogInformation("Event Body: {body}", @event.Body); | ||
| _logger.LogInformation("Event Content-Type: {contentType}", @event.ContentType); | ||
| } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// This functions demonstrates that it is possible to bind to both the <see cref="EventData"/> and any of the supported binding contract | ||
| /// properties at the same time. If attempting this, the <see cref="EventData"/> must be the first parameter. There is not | ||
| /// much benefit to doing this as all of the binding contract properties are available as properties on the <see cref="EventData"/>. | ||
| /// </summary> | ||
| [Function(nameof(EventDataWithStringPropertiesFunction))] | ||
| public void EventDataWithStringPropertiesFunction( | ||
| [EventHubTrigger("queue", Connection = "EventHubConnection")] | ||
| EventData @event, string contentType, long offset) | ||
| { | ||
| // The ContentType property and the contentType parameter are the same. | ||
| _logger.LogInformation("Event Content-Type: {contentType}", @event.ContentType); | ||
| _logger.LogInformation("Event Content-Type: {contentType}", contentType); | ||
|
|
||
| // Similarly the Offset property and the offset parameter are the same. | ||
| _logger.LogInformation("Event offset: {offset}", @event.Offset); | ||
| _logger.LogInformation("Event offset: {offset}", offset); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.