Table converter by aishwaryabh · Pull Request #1506 · Azure/azure-functions-dotnet-worker

aishwaryabh · 2023-05-03T18:43:02Z

Issue describing the changes in this PR

Creating a table converter to enable binding to the TableClient, TableEntity and IEnumerable<TableEntity> types so that we have parity with in-proc.
resolves #1474

Pull request checklist

My changes do not require documentation changes
- Otherwise: Documentation issue linked to PR
My changes should not be added to the release notes for the next release
- Otherwise: I've added my notes to release_notes.md
My changes do not need to be backported to a previous version
- Otherwise: Backport tracked by issue/PR #issue_or_pr
I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

#1374)" This reverts commit eac5b19.

* Adding test project * Added tests

jviau

Meant to approve my last review - all my comments are non-blocking.

liliankasem

Looks great! Just one more comment about the use and creation of TableData then ready to sign off

* Add E2E tests for blob SDK type bindings (#1360) * Add analyzer for SupportsDeferredBindingAttribute (#1367) * Update SupportsDeferredBinding diagnostic code & update docs (#1377) * Revert "Remove types, tests & logic related to the SDK-binding feature (#1374)" This reverts commit eac5b19. * Added unit tests for BlobStorageConverter (#1370) * Adding test project * Added tests * Initial changes * Updating metadata * Adding a test * Code refactoring * Cosmos DB converter for SDK-type support and samples (#1406) * Execution flow added * Update pipeline variables to include tags (#1427) * Update extension variables to not use build number with tags (#1429) * Execution flow * cleanup * Cleanup * Cleanup * Cleanup execution flow * Added test * Adding tests * code cleanup * Code cleanup * code refactor * Added logic to check type before sending to converter * Updated tests * Removing advertised converters from options * Adding options back * Changes to check type * updating type check logic * correction in metadata generation * code cleanup * Test cleanup * Added changes to support poco * Metadata generation changes * Changes on Invocation side * correcting type check and tests * Test for poco invocation support * Added tests for poco invocation flows * Metadata generator minor update * Grpc definition update * Added poco and poco collection check * cleanup metadata generation * Adding support for type collection * code cleanup * Fixing metadata gen * Test fix * Grpc definition fix * Removing BlobContainerClient advertisement * Readding containerclient * Updated metadata generator * Changes as per latest design * code cleanup * updatin tests input * code cleanup * Cleanup Metadata generation * correcting converters fallback logic * Removing converter advertisement on cosmos trigger * Fixing failing test * test check in * Undo testing changes in sample app * spacing fix * updated tests * non secret changes * Addressing PR feedback * e2e test work * adding comments * Removed json deserialization attribute * Rename to AllowConverterFallback * Addressing feedback * Metada generation cleanup * Test cleanup * Addressing feedback * Updated grpcFunctionDefinition for multiple inputConverterAttribute * Removing cosmos converter registration * Address PR feedback * Address PR feedback * Test fix * Minor * addressing comments * getting e2e working * Implement bypass deferred binding (#1462) Implement bypass deferred binding * Build issue fix * comments * Update test/E2ETests/E2EApps/E2EApp/Table/TableInputBindingFunctions.cs Co-authored-by: Lilian Kasem <likasem@microsoft.com> * Adding check for PR in yml file (#1546) * addressing some more comments * dependency * one more dependency * trying to compile lol * seeing if tables project compiles with dependency * removing local instance * see if this compiles * trying to remove test * nvm adding it back * adding keys to nuget.config * trying to get feed * trying again * more yml * fixing spacing * ci.yml * Add ability to bind to SBReceivedMessage (#1313) * another change * trying again * formatting changes * changes * updating worker.sdk package * fixing unit test * getting unit tests to pass * fixing test --------- Co-authored-by: Lilian Kasem <likasem@microsoft.com> Co-authored-by: Surgupta <surgupta@microsoft.com> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

--------- Co-authored-by: Lilian Kasem <likasem@microsoft.com> Co-authored-by: Surgupta <surgupta@microsoft.com> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

* Add E2E tests for blob SDK type bindings (Azure#1360) * Add analyzer for SupportsDeferredBindingAttribute (Azure#1367) * Update SupportsDeferredBinding diagnostic code & update docs (Azure#1377) * Revert "Remove types, tests & logic related to the SDK-binding feature (Azure#1374)" This reverts commit eac5b19. * Added unit tests for BlobStorageConverter (Azure#1370) * Adding test project * Added tests * Initial changes * Updating metadata * Adding a test * Code refactoring * Cosmos DB converter for SDK-type support and samples (Azure#1406) * Execution flow added * Update pipeline variables to include tags (Azure#1427) * Update extension variables to not use build number with tags (Azure#1429) * Execution flow * cleanup * Cleanup * Cleanup * Cleanup execution flow * Added test * Adding tests * code cleanup * Code cleanup * code refactor * Added logic to check type before sending to converter * Updated tests * Removing advertised converters from options * Adding options back * Changes to check type * updating type check logic * correction in metadata generation * code cleanup * Test cleanup * Added changes to support poco * Metadata generation changes * Changes on Invocation side * correcting type check and tests * Test for poco invocation support * Added tests for poco invocation flows * Metadata generator minor update * Grpc definition update * Added poco and poco collection check * cleanup metadata generation * Adding support for type collection * code cleanup * Fixing metadata gen * Test fix * Grpc definition fix * Removing BlobContainerClient advertisement * Readding containerclient * Updated metadata generator * Changes as per latest design * code cleanup * updatin tests input * code cleanup * Cleanup Metadata generation * correcting converters fallback logic * Removing converter advertisement on cosmos trigger * Fixing failing test * test check in * Undo testing changes in sample app * spacing fix * updated tests * non secret changes * Addressing PR feedback * e2e test work * adding comments * Removed json deserialization attribute * Rename to AllowConverterFallback * Addressing feedback * Metada generation cleanup * Test cleanup * Addressing feedback * Updated grpcFunctionDefinition for multiple inputConverterAttribute * Removing cosmos converter registration * Address PR feedback * Address PR feedback * Test fix * Minor * addressing comments * getting e2e working * Implement bypass deferred binding (Azure#1462) Implement bypass deferred binding * Build issue fix * comments * Update test/E2ETests/E2EApps/E2EApp/Table/TableInputBindingFunctions.cs Co-authored-by: Lilian Kasem <likasem@microsoft.com> * Adding check for PR in yml file (Azure#1546) * addressing some more comments * dependency * one more dependency * trying to compile lol * seeing if tables project compiles with dependency * removing local instance * see if this compiles * trying to remove test * nvm adding it back * adding keys to nuget.config * trying to get feed * trying again * more yml * fixing spacing * ci.yml * Add ability to bind to SBReceivedMessage (Azure#1313) * another change * trying again * formatting changes * changes * updating worker.sdk package * fixing unit test * getting unit tests to pass * fixing test --------- Co-authored-by: Lilian Kasem <likasem@microsoft.com> Co-authored-by: Surgupta <surgupta@microsoft.com> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

liliankasem and others added 30 commits February 23, 2023 13:48

Add E2E tests for blob SDK type bindings (#1360)

257add7

Add analyzer for SupportsDeferredBindingAttribute (#1367)

3f84651

Update SupportsDeferredBinding diagnostic code & update docs (#1377)

6b1189a

Revert "Remove types, tests & logic related to the SDK-binding feature (

d16ab2d

#1374)" This reverts commit eac5b19.

Added unit tests for BlobStorageConverter (#1370)

cdcbc9d

* Adding test project * Added tests

Initial changes

f7853d7

Updating metadata

9d105a6

Adding a test

0a4342b

Code refactoring

d5206aa

Cosmos DB converter for SDK-type support and samples (#1406)

fae3f6b

Execution flow added

a4da7dc

Update pipeline variables to include tags (#1427)

1b3395e

Update extension variables to not use build number with tags (#1429)

cb93c71

Execution flow

61479cb

cleanup

356b372

Cleanup

199e6cb

Cleanup

379da90

Cleanup execution flow

71e0be8

Added test

ad21fb9

Adding tests

6e14edf

code cleanup

a398322

Code cleanup

df76646

code refactor

bc9749f

Added logic to check type before sending to converter

0eb9b5f

Updated tests

6630355

Removing advertised converters from options

15752e9

Adding options back

1ef5181

Changes to check type

63af451

updating type check logic

29bcb97

correction in metadata generation

dfac68e

aishwaryabh added 7 commits May 23, 2023 14:50

merging

6e52dc7

changes

bbff7a9

updating worker.sdk package

7683684

fixing unit test

bcd3107

getting unit tests to pass

904d3e7

fixing test

276f803

release notes

b05e4af

liliankasem reviewed May 24, 2023

View reviewed changes

Comment thread extensions/Worker.Extensions.Tables/src/Worker.Extensions.Tables.csproj

aishwaryabh added 2 commits May 24, 2023 15:54

addressing comments

f4540ab

changing cs proj version

7cccefa

jviau reviewed May 24, 2023

View reviewed changes

jviau approved these changes May 24, 2023

View reviewed changes

changes

b08f877

liliankasem reviewed May 25, 2023

View reviewed changes

Comment thread extensions/Worker.Extensions.Tables/src/TypeConverters/TableConverterBase.cs Outdated

fixing build error

270d7fd

liliankasem reviewed May 25, 2023

View reviewed changes

Comment thread extensions/Worker.Extensions.Tables/src/TypeConverters/TableConverterBase.cs

liliankasem reviewed May 25, 2023

View reviewed changes

liliankasem approved these changes May 25, 2023

View reviewed changes

aishwaryabh added 2 commits May 25, 2023 11:32

addressing comments

5656c0b

fix e2e test

0e6dc40

aishwaryabh merged commit db4ad52 into feature/sdk-type-binding May 25, 2023

aishwaryabh deleted the aibhandari/table-converter-legit branch May 25, 2023 21:35

liliankasem mentioned this pull request Aug 11, 2023

SDK-binding support for Tables worker extension #1776

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Table converter#1506

Table converter#1506
aishwaryabh merged 123 commits intofeature/sdk-type-bindingfrom
aibhandari/table-converter-legit

aishwaryabh commented May 3, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jviau left a comment

Uh oh!

Uh oh!

Uh oh!

liliankasem left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

aishwaryabh commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue describing the changes in this PR

Pull request checklist

Additional information

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jviau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

liliankasem left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aishwaryabh commented May 3, 2023 •

edited

Loading