Cosmos DB converter for SDK-type support and samples#1109
Closed
liliankasem wants to merge 13 commits intomainfrom
Closed
Cosmos DB converter for SDK-type support and samples#1109liliankasem wants to merge 13 commits intomainfrom
liliankasem wants to merge 13 commits intomainfrom
Conversation
liliankasem
changed the base branch from
main
to
sdk-bindings/blob-sdk-converter
liliankasem
force-pushed
the
sdk-bindings/blob-sdk-converter
branch
2 times, most recently
from
c2f92bb to
da9457e
Compare
liliankasem
force-pushed
the
sdk-bindings/cosmos-sdk-converter
branch
from
3d5098d to
70656e3
Compare
This was referenced Oct 12, 2022
liliankasem
force-pushed
the
sdk-bindings/blob-sdk-converter
branch
from
37f7bf5 to
d1f7072
Compare
liliankasem
force-pushed
the
sdk-bindings/blob-sdk-converter
branch
5 times, most recently
from
9699643 to
49de716
Compare
liliankasem
force-pushed
the
sdk-bindings/cosmos-sdk-converter
branch
from
075e9f6 to
ec52c4d
Compare
liliankasem
changed the base branch from
sdk-bindings/blob-sdk-converter
to
main
liliankasem
force-pushed
the
sdk-bindings/cosmos-sdk-converter
branch
from
ec52c4d to
75f1b9b
Compare
jviau
reviewed
Dec 14, 2022
Contributor
jviau
left a comment
jviau
left a comment
There was a problem hiding this comment.
I think the main concern is the use of preview Azure.Cosmos over Microsoft.Azure.Cosmos.
If we have to choose one, I would say v3. If we want to support both, we either need separate packages or get crazy with some reflection. And don't reference either package! discover and cache the types/ctors we want via reflection.
jviau
reviewed
Dec 14, 2022
liliankasem
force-pushed
the
sdk-bindings/cosmos-sdk-converter
branch
from
5f0d496 to
8f9fc3a
Compare
jviau
reviewed
Jan 9, 2023
jviau
reviewed
Jan 11, 2023
jviau
approved these changes
Jan 12, 2023
jviau
reviewed
Jan 12, 2023
kshyju
reviewed
Feb 6, 2023
kshyju
reviewed
Feb 6, 2023
Member
|
@liliankasem are you planning on rebasing this PR and making it ready for review? |
Member
Author
Yes; currently deprioritized with focus on testing but will restart work on this PR soon |
7 tasks
Member
Author
|
Created an issue to restart work on this PR |
This was referenced Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1034
Pull request checklist
release_notes.mdAdditional information
Additional PR information