fixing nullable warnings

src/DotNetWorker/Context/DefaultFunctionExecutionContext.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System;
@@ -20,9 +20,9 @@ internal class DefaultFunctionExecutionContext : FunctionExecutionContext, IDisp
         public DefaultFunctionExecutionContext(IServiceScopeFactory serviceScopeFactory, FunctionInvocation invocation,
             FunctionDefinition definition)
         {
-            _serviceScopeFactory = serviceScopeFactory;
-            Invocation = invocation;
-            FunctionDefinition = definition;
+            _serviceScopeFactory = serviceScopeFactory ?? throw new ArgumentNullException(nameof(serviceScopeFactory));
+            Invocation = invocation ?? throw new ArgumentNullException(nameof(invocation));
+            FunctionDefinition = definition ?? throw new ArgumentNullException(nameof(definition));
             OutputBindings = new Dictionary<string, object>();
         }
 
@@ -32,7 +32,7 @@ public DefaultFunctionExecutionContext(IServiceScopeFactory serviceScopeFactory,
 
         public override object? InvocationResult { get; set; }
 
-        public override InvocationLogger Logger { get; set; }
+        public override InvocationLogger? Logger { get; set; }
 
         public override IDictionary<string, object> OutputBindings { get; }
 
@@ -42,19 +42,16 @@ public override IServiceProvider InstanceServices
         {
             get
             {
-                if (_instanceServicesScope == null && _serviceScopeFactory != null)
+                if (_instanceServicesScope == null)
                 {
                     _instanceServicesScope = _serviceScopeFactory.CreateScope();
                     _instanceServices = _instanceServicesScope.ServiceProvider;
                 }
 
-                return _instanceServices;
+                return _instanceServices!;
             }
 
-            set
-            {
-                _instanceServices = value;
-            }
+            set => _instanceServices = value;
         }
 
         public virtual void Dispose()

src/DotNetWorker/Context/FunctionExecutionContext.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System;
@@ -18,7 +18,7 @@ public abstract class FunctionExecutionContext
 
         public abstract object? InvocationResult { get; set; }
 
-        public abstract InvocationLogger Logger { get; set; }
+        public abstract InvocationLogger? Logger { get; set; }
 
         // TODO: Double-check previous projects for layout of FunctionInvocation, Bindings, etc
         public abstract IDictionary<string, object> OutputBindings { get; }

src/DotNetWorker/Converters/Converter/ConverterContext.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 using Microsoft.Azure.Functions.Worker.Definition;
@@ -10,7 +10,7 @@ internal abstract class ConverterContext
     {
         public abstract FunctionParameter Parameter { get; set; }
 
-        public abstract object Source { get; set; }
+        public abstract object? Source { get; set; }
 
         public abstract FunctionExecutionContext ExecutionContext { get; set; }
     }

src/DotNetWorker/Converters/Converter/DefaultConverterContext.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 using Microsoft.Azure.Functions.Worker.Definition;

src/DotNetWorker/Converters/ExactMatchConverter.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 namespace Microsoft.Azure.Functions.Worker.Converters
@@ -7,7 +7,7 @@ internal class ExactMatchConverter : IConverter
     {
         public bool TryConvert(ConverterContext context, out object? target)
         {
-            if (context.Source.GetType() == context.Parameter.Type)
+            if (context.Source?.GetType() == context.Parameter.Type)
             {
                 target = context.Source;
                 return true;

src/DotNetWorker/DefaultOutputBinding.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System.Collections.Generic;
@@ -9,22 +9,23 @@ namespace Microsoft.Azure.Functions.Worker
     internal class DefaultOutputBinding<T> : OutputBinding<T>
     {
         private readonly FunctionParameter _param;
-        private readonly IDictionary<string, object> _outputBindings;
+        private readonly IDictionary<string, object?> _outputBindings;
 
-        public DefaultOutputBinding(FunctionParameter param, IDictionary<string, object> outputBindings)
+        public DefaultOutputBinding(FunctionParameter param, IDictionary<string, object?> outputBindings)
         {
             _param = param;
             _outputBindings = outputBindings;
         }
 
-        public override void SetValue(T value)
+        public override void SetValue(T? value)
         {
             _outputBindings[_param.Name] = value;
         }
 
-        internal override T GetValue()
+        internal override T? GetValue()
         {
-            return (T)_outputBindings[_param.Name];
+            var value = _outputBindings[_param.Name];
+            return (T)value;
         }
     }
 }

src/DotNetWorker/Definition/DefaultFunctionDefinitionFactory.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System;
@@ -54,9 +54,16 @@ public FunctionDefinition Create(FunctionLoadRequest request)
 
             MethodInfo? methodInfo = functionType?.GetMethod(methodName);
 
+            if (methodInfo == null)
+            {
+                throw new InvalidOperationException($"Method '{methodName}' specified in {nameof(FunctionMetadata.EntryPoint)} was not found. This function cannot be created.");
+            }
+
             IFunctionInvoker invoker = _functionInvokerFactory.Create(methodInfo);
 
-            IEnumerable<FunctionParameter> parameters = methodInfo.GetParameters().Select(p => new FunctionParameter(p.Name, p.ParameterType));
+            IEnumerable<FunctionParameter> parameters = methodInfo.GetParameters()
+                .Where(p => p.Name != null)
+                .Select(p => new FunctionParameter(p.Name!, p.ParameterType));
 
             return new DefaultFunctionDefinition(metadata, invoker, parameters);
         }

src/DotNetWorker/Definition/FunctionMetadata.cs

@@ -1,21 +1,16 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
-using System.Collections.Immutable;
-using System.Reflection;
-
 namespace Microsoft.Azure.Functions.Worker
 {
-    public class FunctionMetadata
+    public abstract class FunctionMetadata
     {
-        public string? PathToAssembly { get; set; }
-
-        public string? EntryPoint { get; set; }
+        public abstract string PathToAssembly { get; set; }
 
-        public string? TypeName { get; set; }
+        public abstract string EntryPoint { get; set; }
 
-        public string? FunctionId { get; set; }
+        public abstract string FunctionId { get; set; }
 
-        public string? FuncName { get; set; }        
+        public abstract string Name { get; set; }
     }
 }

src/DotNetWorker/Definition/GrpcFunctionMetadata.cs

@@ -0,0 +1,24 @@
+using System.IO;
+using Microsoft.Azure.WebJobs.Script.Grpc.Messages;
+
+namespace Microsoft.Azure.Functions.Worker.Definition
+{
+    internal class GrpcFunctionMetadata : FunctionMetadata
+    {
+        public GrpcFunctionMetadata(FunctionLoadRequest loadRequest)
+        {
+            EntryPoint = loadRequest.Metadata.EntryPoint;
+            Name = loadRequest.Metadata.Name;
+            PathToAssembly = Path.GetFullPath(loadRequest.Metadata.ScriptFile);
+            FunctionId = loadRequest.FunctionId;
+        }
+
+        public override string PathToAssembly { get; set; }
+
+        public override string EntryPoint { get; set; }
+
+        public override string FunctionId { get; set; }
+
+        public override string Name { get; set; }
+    }
+}

src/DotNetWorker/IFunctionActivator.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System;

src/DotNetWorker/Invocation/DefaultFunctionExecutor.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System.Linq;
@@ -12,8 +12,8 @@ internal class DefaultFunctionExecutor : IFunctionExecutor
         public async Task ExecuteAsync(FunctionExecutionContext context)
         {
             var invoker = context.FunctionDefinition.Invoker;
-            object instance = invoker.CreateInstance(context.InstanceServices);
-            object result = await invoker.InvokeAsync(instance, context.FunctionDefinition.Parameters.Select(p => p.Value).ToArray());
+            object? instance = invoker.CreateInstance(context.InstanceServices);
+            object? result = await invoker.InvokeAsync(instance, context.FunctionDefinition.Parameters.Select(p => p.Value).ToArray());
             context.InvocationResult = result;
         }
     }

src/DotNetWorker/Invocation/DefaultFunctionInvoker.cs

@@ -1,6 +1,8 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
+#nullable disable
+
 using System;
 using System.Threading.Tasks;
 
@@ -24,10 +26,10 @@ public object CreateInstance(IServiceProvider instanceServices)
             return FunctionActivator.CreateInstance<TInstance>(instanceServices);
         }
 
-        public Task<object?> InvokeAsync(object instance, object[] arguments)
+        public Task<object> InvokeAsync(object instance, object[] arguments)
         {
             return _methodInvoker.InvokeAsync((TInstance)instance, arguments)
-                .ContinueWith<object?>(t => t.Result);
+                .ContinueWith<object>(t => t.Result);
         }
     }
 }

src/DotNetWorker/Invocation/DefaultMethodInvokerFactory.cs

@@ -1,6 +1,8 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
+#nullable disable
+
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
@@ -63,7 +65,7 @@ public IMethodInvoker<TInstance, TReturn> Create<TInstance, TReturn>(MethodInfo
                 if (argumentType.IsByRef)
                 {
                     // The type of the local variable (and object in the arguments array) should be T rather than T&.
-                    argumentType = argumentType.GetElementType();
+                    argumentType = argumentType.GetElementType()!;
                 }
 
                 // T argumentN

src/DotNetWorker/Invocation/IFunctionInvoker.cs

@@ -1,6 +1,8 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
+#nullable disable
+
 using System;
 using System.Threading.Tasks;
 
@@ -10,6 +12,6 @@ public interface IFunctionInvoker
     {
         object CreateInstance(IServiceProvider instanceServices);
 
-        Task<object?> InvokeAsync(object instance, object?[] arguments);
+        Task<object> InvokeAsync(object instance, object[] arguments);
     }
 }

src/DotNetWorker/Invocation/IMethodInvoker.cs

@@ -1,6 +1,8 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
+#nullable disable
+
 using System.Threading.Tasks;
 
 namespace Microsoft.Azure.Functions.Worker.Invocation

src/DotNetWorker/Invocation/MethodInvokerWithReturnValue.cs

@@ -1,6 +1,8 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
+#nullable disable
+
 using System;
 using System.Threading.Tasks;
 

src/DotNetWorker/Invocation/TaskMethodInvoker.cs

@@ -1,6 +1,8 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
+#nullable disable
+
 using System;
 using System.Diagnostics;
 using System.Threading.Tasks;

src/DotNetWorker/Invocation/VoidMethodInvoker.cs

@@ -1,6 +1,8 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
+#nullable disable
+
 using System;
 using System.Threading.Tasks;
 

src/DotNetWorker/Invocation/VoidTaskMethodInvoker.cs

@@ -1,6 +1,8 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
+#nullable disable
+
 using System;
 using System.Threading.Tasks;
 

src/DotNetWorker/Logging/InvocationLogger.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System;
@@ -22,7 +22,7 @@ public InvocationLogger(string invocationId, ChannelWriter<StreamingMessage> cha
 
         public IDisposable BeginScope<TState>(TState state)
         {
-            return null;
+            return EmptyDisposable.Instance;
         }
 
         public bool IsEnabled(LogLevel logLevel)
@@ -67,5 +67,14 @@ private static Level ToRpcLogLevel(LogLevel logLevel)
                     return Level.None;
             }
         }
+
+        private class EmptyDisposable : IDisposable
+        {
+            public static IDisposable Instance = new EmptyDisposable();
+
+            public void Dispose()
+            {
+            }
+        }
     }
 }

src/DotNetWorker/NullFunctionActivator.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 using System;
@@ -13,7 +13,7 @@ private NullFunctionActivator()
 
         public static NullFunctionActivator Instance { get; } = new NullFunctionActivator();
 
-        public T CreateInstance<T>(IServiceProvider services)
+        public T? CreateInstance<T>(IServiceProvider services)
         {
             return default(T);
         }