Skip to content

Add input validation to gRPC service implementations#7402

Merged
wbreza merged 5 commits into
mainfrom
feature/extension-framework-ga-hardening
Mar 31, 2026
Merged

Add input validation to gRPC service implementations#7402
wbreza merged 5 commits into
mainfrom
feature/extension-framework-ga-hardening

Address review feedback: idiomatic range loop and t.Context()

2671d52
Select commit
Loading
Failed to load commit list.
Azure Pipelines / azure-dev - cli succeeded Mar 31, 2026 in 1h 8m 50s

Build #20260331.6 had test failures

4 errors / 187 warnings

Details

Tests

  • Failed: 5 (0.01%)
  • Passed: 38,229 (99.71%)
  • Other: 105 (0.27%)
  • Total: 38,339

Annotations

Check failure on line 13 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / azure-dev - cli

Build log #L13 

Error while trying to get OIDC token: Error: connect ETIMEDOUT 150.171.74.16:443

Check failure on line 14 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / azure-dev - cli

Build log #L14 

Error while trying to get OIDC token: Error: connect ENETUNREACH 2603:1061:10::16:443 - Local (:::0)

Check failure on line 15 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / azure-dev - cli

Build log #L15 

Error while trying to get OIDC token: Error: connect ETIMEDOUT 150.171.73.16:443

Check failure on line 16 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / azure-dev - cli

Build log #L16 

Error while trying to get OIDC token: Error: connect ENETUNREACH 2603:1061:10:1::16:443 - Local (:::0)

Check failure on line 1 in TestDetect/Full

See this annotation in the file changed.

@azure-pipelines azure-pipelines / azure-dev - cli

TestDetect/Full 

Failed
Raw output 
=== RUN   TestDetect/Full
=== PAUSE TestDetect/Full
=== CONT  TestDetect/Full
    appdetect_test.go:202: 
        	Error Trace:	D:/a/_work/1/s/cli/azd/internal/appdetect/appdetect_test.go:202
        	Error:      	Received unexpected error:
        	            	scanning directories: detecting java project: error reading pom.xml: mvn help:effective-pom on project 'C:\Users\CLOUDT~1\AppData\Local\Temp\TestDetect3820818906\001\java\pom.xml' failed: exit code: 1, stdout: [INFO] Scanning for projects...
        	            	Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/mojo/maven-metadata.xml
        	            	Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-metadata.xml
        	            	Progress (1): 3.2 kB
Progress (2): 3.2 kB | 4.6 kB
Progress (2): 7.9 kB | 4.6 kB
Progress (2): 12 kB | 4.6 kB 
Progress (2): 16 kB | 4.6 kB
Progress (2): 20 kB | 4.6 kB
Progress (2): 21 kB | 4.6 kB
Progress (2): 21 kB | 9.7 kB
Progress (2): 21 kB | 14 kB 
                           
[WARNING] Could not transfer metadata org.apache.maven.plugins/maven-metadata.xml from/to central (https://repo.maven.apache.org/maven2): C:\Users\cloudtest\.m2\repository\org\apache\maven\plugins\maven-metadata-central.xml.18141871596571091446.tmp.346021860525058288.tmp
        	            	[WARNING] Could not transfer metadata org.codehaus.mojo/maven-metadata.xml from/to central (https://repo.maven.apache.org/maven2): C:\Users\cloudtest\.m2\repository\org\codehaus\mojo\maven-metadata-central.xml.4657497857755753545.tmp
        	            	[WARNING] org.apache.maven.plugins/maven-metadata.xml failed to transfer from https://repo.maven.apache.org/maven2 during a previous attempt. This failure was cached in the local repository and resolution will not be reattempted until the update interval of central has elapsed or updates are forced. Original error: Could not transfer metadata org.apache.maven.plugins/maven-metadata.xml from/to central (https://repo.maven.apache.org/maven2): C:\Users\cloudtest\.m2\repository\org\apache\maven\plugins\maven-metadata-central.xml.18141871596571091446.tmp
        	            	Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/3.2.0/maven-clean-plugin-3.2.0.pom
        	            	Progress (1): 780 B
Progress (1): 1.7 kB
Progress (1): 4.2 kB
Progress (1): 5.3 kB
                    
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/3.2.0/maven-clean-plugin-3.2.0.pom (5.3 kB at 113 kB/s)
        	            	Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/35/maven-parent-35.pom
        	            	Progress (1): 726 B
Progress (1): 1.6 kB
Progress (1): 4.2 kB
Progress (1): 8.4 kB
Progress (1): 11 kB 
Progress (1): 16 kB
Progress (1): 21 kB
Progress (1): 23 kB
Progress (1): 26 kB
Progress (1): 28 kB
Progress (1): 30 kB
Progress (1): 33 kB
Progress (1): 37 kB
Progress (1): 39 kB
Progress (1): 42 kB
Progress (1): 45 kB
                   
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/35/maven-parent-35.pom (45 kB at 1.5 MB/s)
        	            	Downloading from central: https://repo.maven.apache.org/maven2/org/apache/apache/25/apache-25.pom
        	            	Progress (1): 743 B
Progress (1): 1.6 kB
Progress (1): 3.4 kB
Progress (1): 5.5 kB
Progress (1): 9.0 kB
Progress (1): 14 kB 
Progress (1): 17 kB
Progress (1): 19 kB
Progress (1): 21 kB
                   
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/apache/25/apache-25.pom (21 kB at 395 kB/s)
        	            	Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/3.2.0/maven-clean-plugin-3.2.0.jar
        	            	Progress (1): 0.9/36 kB
Progress (1): 2.3/36 kB
Progress (1): 3.6/36 kB
Progress (1): 5.0/3

Check failure on line 1 in TestDetect/ExcludePatterns

See this annotation in the file changed.

@azure-pipelines azure-pipelines / azure-dev - cli

TestDetect/ExcludePatterns 

Failed
Raw output 
=== RUN   TestDetect/ExcludePatterns
=== PAUSE TestDetect/ExcludePatterns
=== CONT  TestDetect/ExcludePatterns
2026/03/31 17:48:02 Detecting projects in directory: C:\Users\CLOUDT~1\AppData\Local\Temp\TestDetect3820818906\001
2026/03/31 17:48:02 Detecting projects in directory: C:\Users\CLOUDT~1\AppData\Local\Temp\TestDetect3820818906\001\assets
2026/03/31 17:48:02 Detecting projects in directory: C:\Users\CLOUDT~1\AppData\Local\Temp\TestDetect3820818906\001\dotnet
2026/03/31 17:48:02 Run exec: 'dotnet msbuild C:\Users\CLOUDT~1\AppData\Local\Temp\TestDetect3820818906\001\dotnet\dotnettestapp.csproj --ignore:.sln --getProperty:IsAspireHost --getItem:ProjectCapability' , exit code: 0
2026/03/31 17:48:02 Run exec: 'dotnet msbuild C:\Users\CLOUDT~1\AppData\Local\Temp\TestDetectDocker1195060638\001\dotnet\dotnettestapp.csproj --ignore:.sln --getProperty:RuntimeIdentifier' , exit code: 0
2026/03/31 17:48:02 Found project dotnet at C:\Users\CLOUDT~1\AppData\Local\Temp\TestDetectDocker1195060638\001\dotnet
    appdetect_test.go:202: 
        	Error Trace:	D:/a/_work/1/s/cli/azd/internal/appdetect/appdetect_test.go:202
        	Error:      	Received unexpected error:
        	            	scanning directories: detecting java project: error reading pom.xml: mvn help:effective-pom on project 'C:\Users\CLOUDT~1\AppData\Local\Temp\TestDetect3820818906\001\java\pom.xml' failed: exit code: 1, stdout: [INFO] Scanning for projects...
        	            	Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/mojo/maven-metadata.xml
        	            	Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-metadata.xml
        	            	Progress (1): 4.6 kB
Progress (1): 9.7 kB
Progress (1): 14 kB 
Progress (2): 14 kB | 3.1 kB
Progress (2): 14 kB | 7.7 kB
Progress (2): 14 kB | 12 kB 
Progress (2): 14 kB | 17 kB
Progress (2): 14 kB | 20 kB
Progress (2): 14 kB | 21 kB
                           
Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/mojo/maven-metadata.xml (21 kB at 4.7 kB/s)
        	            	[WARNING] Could not transfer metadata org.apache.maven.plugins/maven-metadata.xml from/to central (https://repo.maven.apache.org/maven2): C:\Users\cloudtest\.m2\repository\org\apache\maven\plugins\maven-metadata-central.xml.18141871596571091446.tmp
        	            	[WARNING] org.apache.maven.plugins/maven-metadata.xml failed to transfer from https://repo.maven.apache.org/maven2 during a previous attempt. This failure was cached in the local repository and resolution will not be reattempted until the update interval of central has elapsed or updates are forced. Original error: Could not transfer metadata org.apache.maven.plugins/maven-metadata.xml from/to central (https://repo.maven.apache.org/maven2): C:\Users\cloudtest\.m2\repository\org\apache\maven\plugins\maven-metadata-central.xml.18141871596571091446.tmp
        	            	Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/3.2.0/maven-clean-plugin-3.2.0.pom
        	            	Progress (1): 780 B
Progress (1): 1.7 kB
Progress (1): 4.2 kB
Progress (1): 5.3 kB
                    
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/3.2.0/maven-clean-plugin-3.2.0.pom (5.3 kB at 113 kB/s)
        	            	Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/35/maven-plugins-35.pom
        	            	Progress (1): 752 B
Progress (1): 1.7 kB
Progress (1): 3.7 kB
Progress (1): 6.4 kB
Progress (1): 8.2 kB
Progress (1): 9.9 kB
                    
Downloaded from central: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/35/maven-plugins-35.pom (9.9 kB at 619 kB/s)
        	            	Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/35/maven-parent-35.pom

Check failure on line 1 in TestDetect

See this annotation in the file changed.

@azure-pipelines azure-pipelines / azure-dev - cli

TestDetect 

Failed
Raw output 
=== RUN   TestDetect
=== PAUSE TestDetect
=== CONT  TestDetect
--- FAIL: TestDetect (1.94s)

Check failure on line 1 in Test_DeploymentStacks/ResourceGroup_Scope_Up_Down

See this annotation in the file changed.

@azure-pipelines azure-pipelines / azure-dev - cli

Test_DeploymentStacks/ResourceGroup_Scope_Up_Down 

Failed
Raw output 
=== RUN   Test_DeploymentStacks/ResourceGroup_Scope_Up_Down
=== PAUSE Test_DeploymentStacks/ResourceGroup_Scope_Up_Down
=== CONT  Test_DeploymentStacks/ResourceGroup_Scope_Up_Down
    deployment_stacks_test.go:76: DIR: C:\Users\CLOUDT~1\AppData\Local\Temp\Test_DeploymentStacksResourceGroup_Scope_Up_Down2202985739\001
    recording.go:382: recorderProxy started with mode replay at https://127.0.0.1:52112
    deployment_stacks_test.go:90: AZURE_ENV_NAME: azdtest-w988f28
    recording.go:347: recorderProxy: GET https://aka.ms:443/azd/extensions/registry: requested interaction not found
    cli.go:255: 1.558s [stdout] {
    cli.go:255: 1.892s [stdout]   "token": "<redacted>",
    cli.go:255: 1.902s [stdout]   "expiresOn": "2026-04-01T19:23:02Z"
    cli.go:255: 1.902s [stdout] }
    cli.go:255: 130ms [stdout] 
    cli.go:255: 135ms [stdout] Initializing an app to run on Azure (azd init)
    cli.go:255: 135ms [stdout] 
    cli.go:255: 242ms [stdout] Enter a unique environment name: 
    cli.go:255: 246ms [stdout] SUCCESS: Initialized environment azdtest-w988f28.
    cli.go:255: 1.552s [stdout] 
    cli.go:255: 1.552s [stdout] Provisioning Azure resources (azd provision)
    cli.go:255: 1.56s [stdout] Provisioning Azure resources can take some time.
    cli.go:255: 1.56s [stdout] 
    cli.go:255: 1.56s [stdout] Initialize bicep provider
    cli.go:230: [heartbeat] command azd provision in C:\Users\CLOUDT~1\AppData\Local\Temp\Test_DeploymentStacksResourceGroup_Scope_Up_Down2202985739\001 is still running after 10s
    recording.go:347: recorderProxy: POST https://login.microsoftonline.com:443/70a036f6-8e4d-4615-bad6-149c02e7720d/oauth2/v2.0/token: http: invalid Read on closed Body
    cli.go:255: 11.442s [stdout] 
    cli.go:255: 11.459s [stdout] ERROR: initializing provisioning manager: resolving bicep parameters file: fetching current principal id: fetching current user information: getting access token: failed retrieving access token: AzurePipelinesCredential authentication failed. 
    cli.go:255: 11.464s [stdout] POST https://login.microsoftonline.com/70a036f6-8e4d-4615-bad6-149c02e7720d/oauth2/v2.0/token
    cli.go:255: 11.467s [stdout] --------------------------------------------------------------------------------
    cli.go:255: 11.469s [stdout] RESPONSE 400: 400 Bad Request
    cli.go:255: 11.473s [stdout] --------------------------------------------------------------------------------
    cli.go:255: 11.473s [stdout] {
    cli.go:255: 11.475s [stdout]   "error": {
    cli.go:255: 11.477s [stdout]     "code": "http: invalid Read on closed Body"
    cli.go:255: 11.477s [stdout]   }
    cli.go:255: 11.477s [stdout] }
    cli.go:255: 11.481s [stdout] --------------------------------------------------------------------------------
    cli.go:255: 11.485s [stdout] To troubleshoot, visit https://aka.ms/azsdk/go/identity/troubleshoot#apc
    deployment_stacks_test.go:131: 
        	Error Trace:	D:/a/_work/1/s/cli/azd/test/functional/deployment_stacks_test.go:131
        	Error:      	Received unexpected error:
        	            	command 'azd provision in C:\Users\CLOUDT~1\AppData\Local\Temp\Test_DeploymentStacksResourceGroup_Scope_Up_Down2202985739\001' had non-zero exit code: exit status 1
        	Test:       	Test_DeploymentStacks/ResourceGroup_Scope_Up_Down
    --- FAIL: Test_DeploymentStacks/ResourceGroup_Scope_Up_Down (14.13s)
View more details on Azure Pipelines