Skip to content

Use --flag=value syntax in extractGlobalArgs to prevent bool flags leaking as positional args #7212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeffreyCA merged 2 commits into from
Mar 20, 2026
Merged

Use --flag=value syntax in extractGlobalArgs to prevent bool flags leaking as positional args #7212

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b70c679
Use `--flag=value` syntax in `extractGlobalArgs` to prevent bool flag…
JeffreyCA Mar 19, 2026
ebc290b
Add test
JeffreyCA Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cli/azd/cmd/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,7 +1007,9 @@ func extractGlobalArgs() []string {
var result []string
globalFlagSet.VisitAll(func(f *pflag.Flag) {
if f.Changed {
result = append(result, fmt.Sprintf("--%s", f.Name), f.Value.String())
// Use --flag=value syntax to avoid ambiguity. The two-arg form (--flag value)
// doesn't work for boolean flags, where the value is treated as a positional arg.
result = append(result, fmt.Sprintf("--%s=%s", f.Name, f.Value.String()))
Comment thread
JeffreyCA marked this conversation as resolved.
}
})
return result
Expand Down
Loading