azure.ai.agents - Improve azd ai agent init -m validation
#6482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffreyCA
changed the title
JeffreyCA
force-pushed
the
jeffreyca/ext-agents-local-validation
branch
from
321de6f to
d16ceaa
Compare
JeffreyCA
changed the title
azd ai agent init -m validation
JeffreyCA
requested review from
hemarina,
rajeshkamal5050,
tg-msft,
trangevi,
vhvb1989,
wbreza and
weikanglim
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the validation and user experience when initializing AI agents from local manifest files, specifically improving the azd ai agent init -m <local path> command. The changes focus on preventing common errors and providing better warnings when copying files.
Key changes:
- Added comprehensive validation to prevent copying directories into themselves or their subtrees
- Implemented a confirmation prompt with preview when copying more than 10 files/folders
- Fixed panic when providing paths to non-existent files by adding proper error handling
- Improved in-place re-initialization by detecting when manifest already exists in target directory
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| cli/azd/extensions/azure.ai.agents/internal/cmd/init_test.go | Added unit tests for copy validation logic, including subtree prevention and same-path handling |
| cli/azd/extensions/azure.ai.agents/internal/cmd/init_copy.go | New file containing refactored copy validation and directory operations with safety checks |
| cli/azd/extensions/azure.ai.agents/internal/cmd/init.go | Refactored to use new validation functions, improved error handling for non-existent files, and better in-place initialization logic |
| cli/azd/extensions/azure.ai.agents/go.mod | Updated azd CLI dependency version |
| cli/azd/extensions/azure.ai.agents/go.sum | Updated checksums for new azd CLI dependency |
wbreza
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5975
Fixes #6440
This PR improves the validation and UX when initializing agents from a local manifest file (
azd ai agent init -m <local path>) and when initializing from GitHub URL in an unauthenticated/expired auth state.Changes
Add warning and confirmation prompt when agent initialization would result in copying more than 10 top-level files/folders (with preview):
Prevent initialization when target dir is inside the manifest dir to avoid accidentally copying the entire project into itself:
Fix panic when providing path to non-existent file
Improve in-place initialization when the manifest already lives in the target directory (skips copying):
Update
github.com/azure/azure-dev/cli/azdin go.mod with GitHub URL parsing fix from Check GitHub authentication before branch resolution in ParseGitHubUrl #6478