-
Notifications
You must be signed in to change notification settings - Fork 322
New feature: Update spring boot properties file for postgresql #4707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
rujche
wants to merge
21
commits into
Azure:main
from
rujche:feature/update-spring-boot-properties-file-for-postgresql
Closed
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
34d2b10
New feature: Update spring boot properties file for postgresql.
rujche 2c287fb
Fix error caused by container app name too long.
rujche cba79ff
Fix lint error.
rujche fe86ba7
Fix error about jdbc url.
rujche ed61fa0
Fix error about lint.
rujche 2a656b8
Fix "G101: Potential hardcoded credentials (gosec)" by splitting stri…
rujche 15d5182
Improve func: appendToCommaSeperatedValues
rujche 9c48679
Fix typo.
rujche cdc9acd
Put all env name into one place.
rujche 5195647
Fix problem: the line is 133 characters long, which exceeds the maxim…
rujche b16f2ec
Fix this problem:
rujche a3f83b7
Move updating application property file related code from appdetect.g…
rujche 65d37fd
Merge branch 'main' into feature/update-spring-boot-properties-file-f…
rujche d46ed23
Fix lint error.
rujche 4f48b25
Adding "springframework" in cspell.yaml.
rujche e8f1de1
Fix lint error.
rujche eafe0be
Fix test error.
rujche 8fe603b
Merge remote-tracking branch 'upstream/main' into feature/update-spri…
rujche 2df79be
Fix test error: Version filled by effective pom feature.
rujche c94105a
Fix check error by adding copyright.
rujche 633a488
Change RawDependency to RawProject in appdetect.go.
rujche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| package internal | ||
|
|
||
| // todo: keep single source for env name in go lang code and resources.bicept | ||
|
|
||
| const EnvNamePostgresHost = "POSTGRES_HOST" | ||
| const EnvNamePostgresPort = "POSTGRES_PORT" | ||
| const EnvNamePostgresUrl = "POSTGRES_URL" | ||
| const EnvNamePostgresDatabase = "POSTGRES_DATABASE" | ||
| const EnvNamePostgresUsername = "POSTGRES_USERNAME" | ||
|
|
||
| // nolint:gosec | ||
| const EnvNamePostgresPassword = "POSTGRES_PASSWORD" | ||
|
|
||
| const EnvNameRedisHost = "REDIS_HOST" | ||
| const EnvNameRedisPort = "REDIS_PORT" | ||
| const EnvNameRedisEndpoint = "REDIS_ENDPOINT" | ||
| const EnvNameRedisPassword = "REDIS_PASSWORD" | ||
| const EnvNameRedisUrl = "REDIS_URL" | ||
|
|
||
| const EnvNameMongoDbUrl = "MONGODB_URL" | ||
|
|
||
| const EnvNameAzureOpenAiUrl = "AZURE_OPENAI_ENDPOINT" | ||
|
|
||
| func ToEnvPlaceHolder(envName string) string { | ||
| return "${" + envName + "}" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's easier, we can just return the RawProject pom.xml representation and let the "app generation" part decide what to do with that information. I think we want to avoid having additional schema translations