Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to suppress readme #4420

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Add option to suppress readme #4420

merged 2 commits into from
Oct 22, 2024

Conversation

alexweininger
Copy link
Contributor

No description provided.

@bwateratmsft
Copy link
Contributor

@danieljurek Do you know how to get the checks to rerun here? They shouldn't have failed...

@alexweininger
Copy link
Contributor Author

They are failing because

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

@danieljurek
Copy link
Member

danieljurek commented Oct 21, 2024

One needs to use a later version of actions/upload-artifact in the GitHub action YAML file.

To fix, go to this file

uses: actions/upload-artifact@v2
and update the v2 to the v4 which will get you the latest.

      - name: 'Upload azd binary to artifact store (upload-artifact: true only)'
        if: matrix.upload-artifact == true
        uses: actions/upload-artifact@v4       # <---- Change this line
        with:
          name: package
          path: ./ext/vscode/azure-dev*.vsix

@alexweininger
Copy link
Contributor Author

#4471

@bwateratmsft
Copy link
Contributor

Ok, I merged #4471. @alexweininger can you merge main into your PR branch?

@azure-sdk
Copy link
Collaborator

VSCode Extension Installation Instructions

  1. Download the extension at https://azuresdkreleasepreview.blob.core.windows.net/azd/vscode/pr/4420/azure-dev-0.9.0-alpha.1.vsix
  2. Extract the extension from the compressed file
  3. In vscode
    a. Open "Extensions" (Ctrl+Shift+X)
    b. Click the ...\ menu at top of Extensions sidebar
    c. Click "Install from VSIX"
    d. Select location of downloaded file

@bwateratmsft bwateratmsft merged commit 4182b41 into main Oct 22, 2024
13 checks passed
@bwateratmsft bwateratmsft deleted the alex/scarlet-lemur branch October 22, 2024 15:44
@bwateratmsft
Copy link
Contributor

Merged! Thanks @alexweininger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants