Skip to content

Remove experimentation middleware from global middleware list #4416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wbreza merged 2 commits into from
Oct 8, 2024
Merged

Remove experimentation middleware from global middleware list #4416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1992b5
Remove experimentation middleware from global middleware list
wbreza Oct 8, 2024
a8d67f2
Skip exp test
wbreza Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cli/azd/cmd/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,6 @@ func NewRootCmd(
root.
UseMiddleware("debug", middleware.NewDebugMiddleware).
UseMiddleware("ux", middleware.NewUxMiddleware).
UseMiddleware("experimentation", middleware.NewExperimentationMiddleware).
UseMiddlewareWhen("telemetry", middleware.NewTelemetryMiddleware, func(descriptor *actions.ActionDescriptor) bool {
return !descriptor.Options.DisableTelemetry
})
Expand Down
2 changes: 2 additions & 0 deletions cli/azd/test/functional/experiment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ import (

// Verifies that the assignment context returned is included in the telemetry events we capture.
func Test_CLI_Experiment_AssignmentContextInTelemetry(t *testing.T) {
t.Skip("Skipping while experimentation is not enabled")

// CLI process and working directory are isolated
t.Parallel()
ctx, cancel := newTestContext(t)
Expand Down