Support configurable api-version for container app deployments#4272
Support configurable api-version for container app deployments#4272wbreza merged 10 commits intoAzure:mainfrom
api-version for container app deployments#4272Conversation
b8c1479 to
b4aa02e
Compare
ellismg
left a comment
There was a problem hiding this comment.
If we end up moving to a world where we do arm deployments for container apps I'm not sure what this api-version value on azure.yaml is going to mean. But maybe adding it for now and then removing it later (as part of moving container apps to GA) makes sense. I can't think of a better place to capture this information.
Things look reasonable to me here (and cool use of config.Config) but I did notice a few places where we still using the model types which may be unsafe.
c71cfde to
3ee64ee
Compare
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
ellismg
left a comment
There was a problem hiding this comment.
LGTM - Really nicely integrated into the system here - cool to see config leveraged in this new way.
Features
Adds support to specify an explicit
api-versionto use for Container apps that is leveraged during container app deployment to avoid getting and unmarshalling to incompatible api-versions and losing configuration data set in bicep.Updates deployment scenarios to be more loosely coupled to avoid loosing custom configuration data during JSON marshalling to hard coded SDK versions.
If an
apiVersionis not set in the service config the SDK will fall back to use the SDKapi-versionit was originally from.Fixes: #4264
Usage Example
App can be validated with the following fork of todo-aca sample