Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosmos mongo vcore bicep to core templates #3507

Closed

Conversation

john0isaac
Copy link
Contributor

adding cosmos mongo vcore bicep to core infra templates as it doesn't exist.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported identify a customer issue label Mar 8, 2024
@john0isaac john0isaac requested a review from jongio March 8, 2024 22:27
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity identity issues with no activity label May 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity identity issues with no activity label May 24, 2024
@jongio
Copy link
Member

jongio commented Jun 3, 2024

@vhvb1989 you good with this?

@jongio
Copy link
Member

jongio commented Jul 22, 2024

We are moving all module work to AVM, so this should be added there, not there.

@v-xuto - Can you please start a PR into AVM for this work?

@v-xuto
Copy link
Member

v-xuto commented Jul 23, 2024

We are moving all module work to AVM, so this should be added there, not there.

@v-xuto - Can you please start a PR into AVM for this work?

Sure. We will create an AVM PR for it.

@rajeshkamal5050
Copy link
Contributor

Closing based on #3507 (comment)

AlexanderSehr pushed a commit to Azure/bicep-registry-modules that referenced this pull request Oct 1, 2024
## Description

Related PR: Azure/azure-dev#3507

Add a new module `document-db/mongo-cluster` to support new feature.

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes #123
Fixes #456
Closes #123
Closes #456
-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |

|[![avm.res.document-db.mongo-cluster](https://github.com/zedy-wj/bicep-registry-modules/actions/workflows/avm.res.document-db.mongo-cluster.yml/badge.svg?branch=document-db%2FmongoClusters)](https://github.com/zedy-wj/bicep-registry-modules/actions/workflows/avm.res.document-db.mongo-cluster.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

@jongio - for notification.

---------

Co-authored-by: zedy <[email protected]>
Co-authored-by: Menghua Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]>
Co-authored-by: Menghua Chen (MSFT) <[email protected]>
Co-authored-by: Yohan Lasorsa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported identify a customer issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants