Add cosmos mongo vcore bicep to core templates #3507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
customer-reported
jongio
requested changes
Mar 8, 2024
templates/common/infra/bicep/core/database/cosmos/mongo/cosmos-mongo-cluster.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/database/cosmos/mongo/cosmos-mongo-cluster.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/database/cosmos/mongo/cosmos-mongo-cluster.bicep
Show resolved
Hide resolved
templates/common/infra/bicep/core/database/cosmos/mongo/cosmos-mongo-cluster.bicep
Show resolved
Hide resolved
vhvb1989
reviewed
Mar 11, 2024
templates/common/infra/bicep/core/database/cosmos/mongo/cosmos-mongo-cluster.bicep
Show resolved
Hide resolved
templates/common/infra/bicep/core/database/cosmos/mongo/cosmos-mongo-cluster.bicep
Show resolved
Hide resolved
vhvb1989
approved these changes
Mar 16, 2024
jongio
approved these changes
Mar 18, 2024
microsoft-github-policy-service
bot
added
the
no-recent-activity
microsoft-github-policy-service
bot
removed
the
no-recent-activity
|
@vhvb1989 you good with this? |
|
We are moving all module work to AVM, so this should be added there, not there. @v-xuto - Can you please start a PR into AVM for this work? |
Sure. We will create an AVM PR for it. |
This was referenced Jul 23, 2024
|
Closing based on #3507 (comment) |
AlexanderSehr
pushed a commit
to Azure/bicep-registry-modules
that referenced
this pull request
Oct 1, 2024
## Description Related PR: Azure/azure-dev#3507 Add a new module `document-db/mongo-cluster` to support new feature. <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #123 Fixes #456 Closes #123 Closes #456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | |[](https://github.com/zedy-wj/bicep-registry-modules/actions/workflows/avm.res.document-db.mongo-cluster.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> @jongio - for notification. --------- Co-authored-by: zedy <[email protected]> Co-authored-by: Menghua Chen (WICRESOFT NORTH AMERICA LTD) <[email protected]> Co-authored-by: Menghua Chen (MSFT) <[email protected]> Co-authored-by: Yohan Lasorsa <[email protected]>
](https://github.com/zedy-wj/bicep-registry-modules/actions/workflows/avm.res.document-db.mongo-cluster.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding cosmos mongo vcore bicep to core infra templates as it doesn't exist.