-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the infra/core modules to AVM modules #3976
base: main
Are you sure you want to change the base?
Conversation
templates/todo/projects/csharp-cosmos-sql/.repo/bicep/infra/main.bicep
Outdated
Show resolved
Hide resolved
templates/todo/projects/csharp-cosmos-sql/.repo/bicep/infra/main.bicep
Outdated
Show resolved
Hide resolved
templates/todo/projects/csharp-cosmos-sql/.repo/bicep/infra/main.bicep
Outdated
Show resolved
Hide resolved
templates/todo/projects/csharp-sql-swa-func/.repo/bicep/infra/main.bicep
Outdated
Show resolved
Hide resolved
templates/todo/projects/csharp-sql/.repo/bicep/infra/main.bicep
Outdated
Show resolved
Hide resolved
templates/todo/projects/csharp-sql/.repo/bicep/infra/main.bicep
Outdated
Show resolved
Hide resolved
templates/todo/projects/java-mongo-aca/.repo/bicep/infra/main.bicep
Outdated
Show resolved
Hide resolved
templates/todo/projects/java-mongo/.repo/bicep/infra/main.bicep
Outdated
Show resolved
Hide resolved
@jongio Based on your suggestion, the code has been updated. Please review, thanks. |
modify models.py modify parameter name modify parameter name
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
The new AVM for keyvault has default parameter Added a new commit here to set purge protection off as it is currently w/o AVMs. This fixed an issue on EngSys where deleted KV accounts can't be removed due to the protection. @jongio , should the default parameter on AVM be false (instead of true?) Why is it forcing purge protection by default? @benbp, FYI |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
@Menghua1 , you force-pushed your changes erasing my last commit. See my comment: #3976 (comment). I have manually cancel the repo-man pipeline to avoid the issues with purgeProtection enabled. Please disable purge protection from keyvault before running the pipeline again |
Sorry, I forced push and deleted your commit. |
@jongio According to your suggestion, we have now added two shared app modules in infra/app, namely web-avm.bicep and api-avm.bivep. The creation of |
That uses pm2, which is for node only right? I think we need to look at what azd infra/core has today and potentially bring more of those files over to infra/app. For each of node, python, etc. |
@jongio web-avm.bicep is applicable to all front-ends using appservice (only for node), api-avm.bivep is applicable to all back-ends using appservice (for all language), and these two files can be applied to all repos using appservice in azure-dev. In addition, we will migrate all bicep files in
|
Let's update this PR to use the new PTN modules as well so we do all of the move to AVM and the new infra/app modules in one PR. Let's not wrap any modules that don't need to be wrapped. If they are simple and don't require defaults, then okay to directly reference. |
@jongio We have wrapped the following five modules into
Besides, for modules that are simple and do not need default values, there is no wrapper. Currently only |
Does the App Service module that you're using include the right variable for AppInsights connection? The current version in azd does not, see my PR here: |
@pamelafox Not included, but now it has been added to the current PR according to PR4491, relevant commits: 8910cac |
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: todo-csharp-cosmos-sqlRemote: azure-samples-stagingBranch: pr/3976You can initialize this project with: azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/3976 View Changes | Compare Changes Project: todo-csharp-sql-swa-funcRemote: azure-samples-stagingBranch: pr/3976You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/3976 View Changes | Compare Changes Project: todo-csharp-sqlRemote: azure-samples-stagingBranch: pr/3976You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql -b pr/3976 View Changes | Compare Changes Project: todo-java-mongo-acaRemote: azure-samples-stagingBranch: pr/3976You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo-aca -b pr/3976 View Changes | Compare Changes Project: todo-java-mongoRemote: azure-samples-stagingBranch: pr/3976You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo -b pr/3976 View Changes | Compare Changes Project: todo-nodejs-mongo-acaRemote: azure-samples-stagingBranch: pr/3976You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/3976 View Changes | Compare Changes Project: todo-nodejs-mongo-aksRemote: azure-samples-stagingBranch: pr/3976You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/3976 View Changes | Compare Changes Project: todo-nodejs-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/3976You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/3976 View Changes | Compare Changes Project: todo-nodejs-mongoRemote: azure-samples-stagingBranch: pr/3976You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo -b pr/3976 View Changes | Compare Changes Project: todo-python-mongo-acaRemote: azure-samples-stagingBranch: pr/3976You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-aca -b pr/3976 View Changes | Compare Changes Project: todo-python-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/3976You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/3976 View Changes | Compare Changes Project: todo-python-mongoRemote: azure-samples-stagingBranch: pr/3976You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo -b pr/3976 View Changes | Compare Changes |
@jongio At present, the migration to AVM has been completed. We have also done some simple testing of all templates locally and they have all been provisioned and deployed successfully. However, the CI of this pr failed because |
@vhvb1989 or @danieljurek any thoughts on these failures? |
the test-templates pipelines is currently disabled/not-working. |
Fixes: #3327
@jongio for notification.