This repository was archived by the owner on Jan 28, 2022. It is now read-only.
Simplify prometheus metrics with labels #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartleeks
changed the title
stuartleeks
force-pushed
the
f-metrics-withlabels
branch
from
9a15e64 to
37eeba1
Compare
Azadehkhojandi
approved these changes
Dec 19, 2019
Contributor
Azadehkhojandi
left a comment
Azadehkhojandi
left a comment
There was a problem hiding this comment.
thanks for your pr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@storey247 and I both worked on this PR to simplify the generated prometheus metrics but consolidating multiple metrics that each contained the object type in the name (e.g.
databricks_dcluster_create_request_duration_seconds) into a single metricdatabricks_request_duration_seconds. The metrics have labels attached sodatabricks_request_duration_seconds{object_type='dcluster'}gives the metric filtered todclusteroperations.This is in line with the way Kubernetes emits metrics, and gives a lot more power for producing dashboards of the metrics in Grafana