This repository was archived by the owner on Jan 28, 2022. It is now read-only.
update the run state before fetching runoutput #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azadehkhojandi
previously approved these changes
Dec 17, 2019
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Sorry, there were some rebase conflicts and issues i had to resolve because of the other PR's that had gone in |
Collaborator
|
@Azadehkhojandi - I see that you approved this earlier. Are you ok to give this a quick check again now that @storey247 has rebased, and merge if it looks ok? |
Azadehkhojandi
approved these changes
Dec 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #130
Updating the run instance before calling the
RunsGetOutputmethod means that if the call toRunsGetOutputfails then the newly created run is updated in K8s correctly and wont have invalid state.