Skip to content
This repository was archived by the owner on Jan 28, 2022. It is now read-only.

Adding support for using existing_cluster_name #126

Merged
merged 3 commits into from
Dec 1, 2019
Merged

Adding support for using existing_cluster_name #126

merged 3 commits into from
Dec 1, 2019

Conversation

@Azadehkhojandi
Copy link
Contributor

@Azadehkhojandi Azadehkhojandi commented Nov 28, 2019

This will close #86

@Azadehkhojandi Azadehkhojandi force-pushed the issue/86 branch 5 times, most recently from c358c49 to cb8f530 Compare November 28, 2019 04:50
@JasonTheDeveloper
Copy link
Contributor

JasonTheDeveloper commented Nov 29, 2019

Looks good to me. One comment though. I noticed there's a helpers.go under api/alphav1 with funcs for generating random string characters but there's also randomStringWithCharset in controllers/suit_test.go. It might be good to rip it out and put helpers.go in a folder accessible to all tests.

JasonTheDeveloper
JasonTheDeveloper approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@JasonTheDeveloper JasonTheDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Azadehkhojandi Azadehkhojandi merged commit 8a81450 into Azure:master Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JasonTheDeveloper JasonTheDeveloper JasonTheDeveloper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding support for using existing_cluster_name as well as existing_cluster_id

2 participants

@Azadehkhojandi @JasonTheDeveloper