This repository was archived by the owner on Jan 28, 2022. It is now read-only.
Extended databricks operator to report metrics into Prometheus #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
storey247
commented
Nov 12, 2019
storey247
commented
- Extended workflow of controllers to report upstream call times and counts
- Identified a couple of issues with linting and patched as found
- Refactored some code to make it more readable
Azadehkhojandi
suggested changes
Nov 25, 2019
Contributor
Azadehkhojandi
left a comment
Azadehkhojandi
left a comment
There was a problem hiding this comment.
Awesome work and I learnt a lot by reviewing your pr.
Could you please cherry-pick only changes related to metrics and apply the minor changes I requested?
Contributor
|
/azp list |
|
CI/CD Pipelines for this repository: |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@Azadehkhojandi thanks for the great feedback, I've tidied things up now and actioned the feedback you requested. The PR should now only contain the commits relevant to the metrics work I did (apologies for the confusion). Looking forward to your feedback |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azadehkhojandi
suggested changes
Dec 4, 2019
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stuartleeks
force-pushed
the
f-metrics
branch
3 times, most recently
from
e152cb6 to
8960a26
Compare
stuartleeks
force-pushed
the
f-metrics
branch
from
8960a26 to
bfbe50c
Compare
stuartleeks
force-pushed
the
f-metrics
branch
from
bfbe50c to
0fe919d
Compare
stuartleeks
force-pushed
the
f-metrics
branch
from
0fe919d to
9608cad
Compare
Collaborator
|
After our discussion earlier this week I have rebased this PR on latest master and dropped out most of the kustomize changes (which are essentially incorporated into the kubebuilder upgrade now in master) with a couple of minor tweaks left in to enable prometheus to connect. I've tested this locally by doing the following in the devcontainer
|
Azadehkhojandi
approved these changes
Dec 17, 2019
amrasem
added a commit
to amrasem/azure-databricks-operator
that referenced
this pull request
Jan 15, 2020
Extended databricks operator to report metrics into Prometheus (Azure#104)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.