This repository was archived by the owner on Jan 28, 2022. It is now read-only.
Beefing up SecretScope #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azadehkhojandi
suggested changes
Nov 2, 2019
Contributor
Azadehkhojandi
left a comment
Azadehkhojandi
left a comment
There was a problem hiding this comment.
Let's have a chat with @devlace about ACL at Oneweek :)
JasonTheDeveloper
force-pushed
the
fix/acl-99
branch
from
5ac67a8 to
8d31e9d
Compare
JasonTheDeveloper
force-pushed
the
fix/acl-99
branch
from
8d31e9d to
7c3e2bf
Compare
JasonTheDeveloper
force-pushed
the
fix/acl-99
branch
from
140973f to
efe6a86
Compare
stuartleeks
added a commit
to stuartleeks/azure-databricks-operator
that referenced
this pull request
Nov 25, 2019
JasonTheDeveloper
force-pushed
the
fix/acl-99
branch
from
a4c4b6e to
85e7b9b
Compare
jakkaj
reviewed
Dec 2, 2019
Also cleaned up the reconcile loop.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #99 and in it I've:
aclsare not set in config, don't do anything with ACLs.If secret scope exists or ACL is not supported, report event and remove from reconcile loop.
If the referenced secret does not exist, report event and put back on reconcile loop.