Fixing a issue where feedoptions are getting overridden #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y they are being initialized.
mbhaskar
requested review from
David-Noble-at-work,
kushagraThapar and
moderakh
as code owners
moderakh
approved these changes
Jan 30, 2020
mbhaskar
added a commit
to mbhaskar/azure-sdk-for-java
that referenced
this pull request
Feb 10, 2020
kushagraThapar
pushed a commit
to Azure/azure-sdk-for-java
that referenced
this pull request
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc producers are spun for each partition range, and each one should have its own copy of feedoptions. In the existing implementation same copy of feedoptions is being used for all the producers due to which there is a possibility of loosing continuation token depending on the order of creation of document producers when multiple (>2) partition ranges are present. This PR addresses this issue and ensures feedoptions are set properly for each producer.