[DO NOT MERGE] Issue #288 : Port RntbdRequestTimer memory leak fix from V4 #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 9, 2019 14:38
… caused the status code to be set incorrectly
… and added DocumentClientExceptionTest.statusCodeIsCorrect The latter resulted in moving DocuemntClientExceptionTest from commons to direct-impl. Without the move commons would need to take a dependency on direct-impl which seems undesirable.
…ns and direct-impl
…into danoble/issue-263/retry-not-happening
…e state of a request when it times out
…into issue/#286/port-from-v4
added 6 commits
November 8, 2019 15:30
David-Noble-at-work
changed the title
David-Noble-at-work
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE DO NOT REVIEW UNTIL PR #287 IS COMPLETE
See #288 and Azure/azure-sdk-for-java#6251