null return fix and logging #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moderakh
requested review from
David-Noble-at-work,
christopheranderson and
kushagraThapar
as code owners
kushagraThapar
requested changes
Oct 5, 2019
Member
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
We should also update the version 2.6.2 in README (version update, and change log update). It becomes later to figure out why we released new version.
Can you please also include the bug fix I made for this: #261
.../main/java/com/microsoft/azure/cosmosdb/internal/directconnectivity/HttpTransportClient.java
Outdated
Show resolved
Hide resolved
.../main/java/com/microsoft/azure/cosmosdb/internal/directconnectivity/GatewayAddressCache.java
Show resolved
Hide resolved
.../main/java/com/microsoft/azure/cosmosdb/internal/directconnectivity/GatewayAddressCache.java
Outdated
Show resolved
Hide resolved
kushagraThapar
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential NPE issue and adds more logging.