Retrieving query info using new query plan retriever#111
Merged
Conversation
Retrieving query info using new query plan retriever
mbhaskar
requested review from
christopheranderson,
kushagraThapar and
moderakh
as code owners
christopheranderson
approved these changes
May 10, 2019
Contributor
christopheranderson
left a comment
christopheranderson
left a comment
There was a problem hiding this comment.
Approved assuming Brandon signs off. Also left 2 comments.
Contributor
|
Also, please create an issue/PR to track the v3 port of this change before we merge. |
Contributor
|
Please see if you can remove the multiple addition single toObservable in the new block of code. If you could rely on Single.toFlatMap() that would be better and you can do less transformation. Also you have test failure. other than that looks good. |
moderakh
approved these changes
May 10, 2019
bchong95
suggested changes
May 10, 2019
Member
Author
|
bchong95
reviewed
Jun 3, 2019
bchong95
approved these changes
Jun 3, 2019
bchong95
reviewed
Jul 12, 2019
bchong95
approved these changes
Jul 12, 2019
moderakh
reviewed
Jul 15, 2019
Contributor
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
does ReadMyWrite test pass?
moderakh
suggested changes
Jul 15, 2019
Contributor
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
please address/respond to the comments.
moderakh
approved these changes
Jul 22, 2019
Contributor
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
Thank you Bhaskar for addressing the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing proxy execution context
Retrieving query info using new query plan retriever
This change is