Skip to content

Diagnostics: Removes Unnecessary APIs From Public Contract #5919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Meghana-Palaparthi merged 4 commits into from
Jun 2, 2026
+0 −30
Merged

Diagnostics: Removes Unnecessary APIs From Public Contract #5919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e64d14e
Code changes to remove unnecessary APIs from pub contract.
kundadebdatta Jun 2, 2026
3530460
Update DotNetSDKAPI.net6.json
Meghana-Palaparthi Jun 2, 2026
32e562c
Add HashCode and Equals implementation back and update contracts
Meghana-Palaparthi Jun 2, 2026
831499b
Update RequestedRegionTests.cs
Meghana-Palaparthi Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions Microsoft.Azure.Cosmos/src/Diagnostics/RequestedRegion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,21 +83,5 @@ public override string ToString()
{
return $"{this.RegionName}:{this.Reason}";
}

/// <summary>
/// Equality operator.
/// </summary>
/// <param name="left">The left operand.</param>
/// <param name="right">The right operand.</param>
/// <returns><c>true</c> if the two values are equal; otherwise <c>false</c>.</returns>
public static bool operator ==(RequestedRegion left, RequestedRegion right) => left.Equals(right);

/// <summary>
/// Inequality operator.
/// </summary>
/// <param name="left">The left operand.</param>
/// <param name="right">The right operand.</param>
/// <returns><c>true</c> if the two values are not equal; otherwise <c>false</c>.</returns>
public static bool operator !=(RequestedRegion left, RequestedRegion right) => !left.Equals(right);
}
}
10 changes: 0 additions & 10 deletions Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetSDKAPI.net6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8775,16 +8775,6 @@
"Attributes": [],
"MethodInfo": "Microsoft.Azure.Cosmos.RequestedRegionReason Reason;CanRead:True;CanWrite:False;Microsoft.Azure.Cosmos.RequestedRegionReason get_Reason();IsAbstract:False;IsStatic:False;IsVirtual:False;IsGenericMethod:False;IsConstructor:False;IsFinal:False;"
},
"System.Boolean Microsoft.Azure.Cosmos.RequestedRegion.op_Equality(Microsoft.Azure.Cosmos.RequestedRegion, Microsoft.Azure.Cosmos.RequestedRegion)": {
"Type": "Method",
"Attributes": [],
"MethodInfo": "System.Boolean Microsoft.Azure.Cosmos.RequestedRegion.op_Equality(Microsoft.Azure.Cosmos.RequestedRegion, Microsoft.Azure.Cosmos.RequestedRegion);IsAbstract:False;IsStatic:True;IsVirtual:False;IsGenericMethod:False;IsConstructor:False;IsFinal:False;"
},
"System.Boolean Microsoft.Azure.Cosmos.RequestedRegion.op_Inequality(Microsoft.Azure.Cosmos.RequestedRegion, Microsoft.Azure.Cosmos.RequestedRegion)": {
"Type": "Method",
"Attributes": [],
"MethodInfo": "System.Boolean Microsoft.Azure.Cosmos.RequestedRegion.op_Inequality(Microsoft.Azure.Cosmos.RequestedRegion, Microsoft.Azure.Cosmos.RequestedRegion);IsAbstract:False;IsStatic:True;IsVirtual:False;IsGenericMethod:False;IsConstructor:False;IsFinal:False;"
},
"System.String get_RegionName()[System.Runtime.CompilerServices.CompilerGeneratedAttribute()]": {
"Type": "Method",
"Attributes": [
Expand Down
4 changes: 0 additions & 4 deletions ...osoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Diagnostics/RequestedRegionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ public void Equality_RegionNameIsCaseInsensitive()
RequestedRegion b = new RequestedRegion("east us", RequestedRegionReason.Initial);

Assert.IsTrue(a.Equals(b));
Assert.IsTrue(a == b);
Assert.IsFalse(a != b);
Assert.IsTrue(a.Equals((object)b));
Assert.AreEqual(a.GetHashCode(), b.GetHashCode());
}
Expand All @@ -45,8 +43,6 @@ public void Equality_DifferentReason_NotEqual()
RequestedRegion b = new RequestedRegion("East US", RequestedRegionReason.Hedging);

Assert.IsFalse(a.Equals(b));
Assert.IsTrue(a != b);
Assert.IsFalse(a == b);
}

[TestMethod]
Expand Down
Loading