Direct: Fixes Direct/TCP connection limit validation#5883
Closed
orange-dot wants to merge 1 commit into
Closed
Conversation
Author
|
@microsoft-github-policy-service agree |
orange-dot
force-pushed
the
issue-5878-direct-tcp-validation
branch
from
6afa730 to
3f61c13
Compare
orange-dot
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
jeet1995,
khdang,
kirankumarkolli,
kundadebdatta,
kushagraThapar,
neildsh,
sboshra and
xinlian12
as code owners
orange-dot
force-pushed
the
issue-5878-direct-tcp-validation
branch
from
3f61c13 to
8d4c0aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaxRequestsPerTcpConnectionrejects values below the documented minimum of 4.MaxTcpConnectionsPerEndpointrejects values below the documented minimum of 16.CosmosClientOptionsandConnectionPolicypaths.Fixes
Tests
DOTNET_ROLL_FORWARD=Major dotnet test Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Microsoft.Azure.Cosmos.Tests.csproj --filter "VerifyCosmosClientOptionsDirectTcpConnectionLimitsValidateMinimumValues|VerifyConnectionPolicyDirectTcpConnectionLimitsValidateMinimumValues" --no-restore /p:EnableSourceControlManagerQueries=falseDOTNET_ROLL_FORWARD=Major dotnet test Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Microsoft.Azure.Cosmos.Tests.csproj --filter "CosmosClientOptionsUnitTests" --no-restore /p:EnableSourceControlManagerQueries=false