[Internal] Tests: Fixes Availability Strategy emulator test timing margins#5713
Merged
kirankumarkolli merged 2 commits intoMar 20, 2026
Merged
Conversation
…rgins Increases timing margins in AvailabilityStrategyNoTriggerTest and AvailabilityStrategyAllFaultsTests to eliminate flaky failures caused by tight delay-vs-threshold margins on CI agents. - AvailabilityStrategyNoTriggerTest: delay 200ms→500ms, threshold 150ms→300ms - AvailabilityStrategyAllFaultsTests: threshold 100ms→200ms Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
NaluTripician
requested review from
FabianMeiswinkel,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
kirankumarkolli
approved these changes
Mar 19, 2026
kirankumarkolli
deleted the
users/nalutripician/test-fix-availability-strategy-timing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increases timing margins in availability strategy emulator tests to eliminate flaky failures caused by tight delay-vs-threshold margins on loaded CI agents.
Changes
AvailabilityStrategyNoTriggerTest (87.97% pass rate — 54 failures in 30 days)
Root cause: Injected response delay (200ms) barely exceeded the hedging threshold (150ms), leaving only 50ms margin. On loaded CI agents, timing jitter caused inconsistent behavior.
Fix: Increased delay to 500ms and threshold to 300ms, providing a 200ms safety margin.
AvailabilityStrategyAllFaultsTests (94.65% pass rate — 24 failures in 30 days)
Root cause: 90 DataRow combinations with a 100ms hedging threshold that was too tight for CI environments.
Fix: Increased hedging threshold from 100ms to 200ms.
Impact