Docs: Add 'fix at source' anti-pattern to IssueFixAgent#5598
Merged
kirankumarkolli merged 2 commits intomasterfrom Feb 2, 2026
Merged
Docs: Add 'fix at source' anti-pattern to IssueFixAgent#5598kirankumarkolli merged 2 commits intomasterfrom
kirankumarkolli merged 2 commits intomasterfrom
Conversation
Adds guidance to fix bugs at the source of invalid state rather than adding defensive checks at callers. This ensures: - Clear error messages at the source - Prevents same bug pattern in other callers - Keeps error handling centralized
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
Adds an audit checklist to the PR description template to ensure all IssueFixAgent workflow checkpoints are followed: - Pre-branch search for existing PRs/branches - Local build and test validation - Root cause documentation - Investigation steps in PR body - Issue comment posted
kirankumarkolli
requested review from
FabianMeiswinkel,
Pilchie and
sboshra
as code owners
kirankumarkolli
deleted the
users/kirankk/copilot-agent-plan-fix-at-source
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds guidance to the IssueFixAgent plan about fixing bugs at the source of invalid state rather than adding defensive checks at callers.
New Anti-Pattern Added
Why This Matters
Learned From
Issue #5596 investigation - the fix was to add isDisposed check in GetStoreProxy() rather than improving the null check in TransportHandler.
Generated by GitHub Copilot CLI Agent