Semantic Reranking: Refactors RerankResult.Document to return string type#5528
Merged
kirankumarkolli merged 4 commits intoDec 16, 2025
Merged
Conversation
NaluTripician
requested review from
FabianMeiswinkel,
Pilchie,
kirankumarkolli and
sboshra
as code owners
kirankumarkolli
approved these changes
Dec 16, 2025
ananth7592
approved these changes
Dec 16, 2025
kirankumarkolli
deleted the
users/nalutripician/semanticRerankParseFix
branch
NaluTripician
added a commit
that referenced
this pull request
Dec 17, 2025
…ng` type (#5528) # Pull Request Template ## Description This pull request updates the handling of the `Document` property in the `RerankScore` class and its deserialization logic to consistently use a `string` type instead of a generic `object`. This change simplifies the type system and ensures that document content or identifiers are always represented as strings which is returned by the service. Type consistency and deserialization improvements: * Changed the `Document` property in the `RerankScore` class from `object` to `string`, and updated the constructor accordingly to require a `string` document. [[1]](diffhunk://#diff-8278775c5227f8e0f3aa61d4b0a96434387143cde3ea6a4e1d4445362a559530L21-R21) [[2]](diffhunk://#diff-8278775c5227f8e0f3aa61d4b0a96434387143cde3ea6a4e1d4445362a559530L39-R39) * Updated the deserialization logic in `DeserializeSemanticRerankResult` to always store the document as a string, either by using the raw JSON text for objects or the string value directly, ensuring type consistency throughout the codebase. ## Type of change Please delete options that are not relevant. - [] Bug fix (non-breaking change which fixes an issue) ## Closing issues To automatically close an issue: closes #IssueNumber
microsoft-github-policy-service Bot
pushed a commit
that referenced
this pull request
Dec 17, 2025
# Pull Request Template ## Description Adds cherry-picks for release branch: #5528 - Semantic Reranking type fix #5531 - Version change / contracts ## Type of change Please delete options that are not relevant. - [] New feature (non-breaking change which adds functionality) ## Closing issues To automatically close an issue: closes #IssueNumber
NaluTripician
added a commit
that referenced
this pull request
Jan 14, 2026
…ng` type (#5528) # Pull Request Template ## Description This pull request updates the handling of the `Document` property in the `RerankScore` class and its deserialization logic to consistently use a `string` type instead of a generic `object`. This change simplifies the type system and ensures that document content or identifiers are always represented as strings which is returned by the service. Type consistency and deserialization improvements: * Changed the `Document` property in the `RerankScore` class from `object` to `string`, and updated the constructor accordingly to require a `string` document. [[1]](diffhunk://#diff-8278775c5227f8e0f3aa61d4b0a96434387143cde3ea6a4e1d4445362a559530L21-R21) [[2]](diffhunk://#diff-8278775c5227f8e0f3aa61d4b0a96434387143cde3ea6a4e1d4445362a559530L39-R39) * Updated the deserialization logic in `DeserializeSemanticRerankResult` to always store the document as a string, either by using the raw JSON text for objects or the string value directly, ensuring type consistency throughout the codebase. ## Type of change Please delete options that are not relevant. - [] Bug fix (non-breaking change which fixes an issue) ## Closing issues To automatically close an issue: closes #IssueNumber
This was referenced Jan 21, 2026
This was referenced Mar 19, 2026
Bump Microsoft.Azure.Cosmos from 3.17.0 to 3.57.1
azureossd/general-database-connectivity-samples#18
Merged
This was referenced Apr 6, 2026
This was referenced Apr 13, 2026
This was referenced Apr 20, 2026
This was referenced Apr 27, 2026
Open
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This pull request updates the handling of the
Documentproperty in theRerankScoreclass and its deserialization logic to consistently use astringtype instead of a genericobject. This change simplifies the type system and ensures that document content or identifiers are always represented as strings which is returned by the service.Type consistency and deserialization improvements:
Documentproperty in theRerankScoreclass fromobjecttostring, and updated the constructor accordingly to require astringdocument. [1] [2]DeserializeSemanticRerankResultto always store the document as a string, either by using the raw JSON text for objects or the string value directly, ensuring type consistency throughout the codebase.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber