Proposal: Change feed metadata to use attribute level json converter#5466
Closed
yash2710 wants to merge 21 commits into
Closed
Proposal: Change feed metadata to use attribute level json converter#5466yash2710 wants to merge 21 commits into
yash2710 wants to merge 21 commits into
Conversation
…adata.cs Co-authored-by: Kiran Kumar Kolli <kirankk@microsoft.com>
…adata.cs Co-authored-by: Kiran Kumar Kolli <kirankk@microsoft.com>
- Update the tests to rely on metadata only as previous image is no longer available
yash2710
requested review from
a team,
FabianMeiswinkel,
Pilchie,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
| /// Applicable for delete operations only, otherwise null. | ||
| /// The id of the previous item version. | ||
| /// </summary> | ||
| [JsonProperty(PropertyName = ChangeFeedMetadataFields.Id, NullValueHandling = NullValueHandling.Ignore)] |
Member
There was a problem hiding this comment.
Its only addresses for Newtonsoft right?
Member
There was a problem hiding this comment.
Closed offline to use a different approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding on to #5191, the proposal is to use
JsonPropertyandJsonConverterat attribute level instead of class level.This PR includes all changes from #5191 and the additional changes.
Updates tests to reflect that the previous image might not be available for delete operations