-
Notifications
You must be signed in to change notification settings - Fork 524
Build: Removes System.Net.Http and System.Text.RegularExpressions package references #5386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ananth7592 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
…erences Co-authored-by: ananth7592 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Removes explicit package references to
System.Net.HttpandSystem.Text.RegularExpressionsfrom the Microsoft.Azure.Cosmos project to resolve security vulnerability warnings when using NuGet audit mode.Resolves github issue: #5216
Problem
The Microsoft.Azure.Cosmos package was explicitly referencing
System.Net.Http(v4.3.4) andSystem.Text.RegularExpressions(v4.3.1) even though it targets .NET Standard 2.0. According to Microsoft's official guidelines, these packages should not be directly referenced for .NET Standard 2.0 projects because:System.Private.Uri4.3.0) that have known security vulnerabilitiesNuGetAuditMode=allUsers experienced build failures like:
Solution
<PackageReference Include="System.Net.Http" Version="4.3.4" />from Microsoft.Azure.Cosmos.csproj<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />from Microsoft.Azure.Cosmos.csprojDirectContractTests.csto reflect the removalVerification
HttpClientandRegexfunctionality preserved through .NET Standard 2.0 APIsNuGetAuditMode=allandTreatWarningsAsErrors=truepassesThe changes are minimal and surgical - only removing unnecessary package references while maintaining full API compatibility.
Fixes #5216.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.