Trace: Fixes thread safety issue in Trace class causing high CPU usage and InvalidOperationException #5360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…concurrent access Co-authored-by: kirankumarkolli <[email protected]>
…tion points Co-authored-by: kirankumarkolli <[email protected]>
…tions Co-authored-by: kirankumarkolli <[email protected]>
Since isBeingWalked flag prevents modifications during enumeration, snapshot methods are no longer needed. The trace system now uses direct enumeration with walking state protection instead of creating copies. Co-authored-by: kirankumarkolli <[email protected]>
…mosTraceDiagnostics Co-authored-by: kirankumarkolli <[email protected]>
Co-authored-by: kirankumarkolli <[email protected]>
…move parameter Co-authored-by: kirankumarkolli <[email protected]>
… adjust assignment order Co-authored-by: kirankumarkolli <[email protected]>
…as started - but instead just operate on cloned snapshots
FabianMeiswinkel
requested review from
Pilchie,
adityasa,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
Member
Author
|
Closing this - opened #5361 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
When cross-region hedging is enabled in the Azure Cosmos DB .NET SDK, users experience high CPU usage or InvalidOperationExceptions ue to thread safety issues when accessing dictionaries in the Trace class. The issue occurs in the AddOrUpdateDatum method where multiple parallel threads attempt to update the same dictionary without proper synchronization.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber