Query: Fixes non streaming order by queries to not be tagged as passthrough queries #5273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is eligible for passthrough
neildsh
requested review from
FabianMeiswinkel,
adityasa,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
sc978345
approved these changes
Jul 8, 2025
microsoft-github-policy-service
bot
deleted the
users/ndeshpan/passthroughFix
branch
This was referenced Aug 15, 2025
This was referenced Oct 6, 2025
Merged
This was referenced Oct 13, 2025
This was referenced Oct 20, 2025
This was referenced Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the addition of non-streaming order by, it is no longer safe to treat single partition order by queries as passthrough, as it can lead to incorrect results for
ORDER BY VectorDistanceandORDER BY RANKqueries. This PR fixes the issue by adding a check for non-streaming order by queries in the passthrough query creation logic.Type of change
Please delete options that are not relevant.