Query : Fixes Skip + Order By Bug

[Maya-Painter]

Description

Addresses a bug where the top value was being set > int.Max for queries with ORDER BY and SKIP clauses. This triggered an assert and caused query failures.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Closing issues

closes #5016

[adityasa]

            Debug.Assert(queryInfo.Top.Value <= int.MaxValue, "PipelineFactory Assert!", "Top value must be <= int.MaxValue");

Do we need to repeat the original check here? What happens if query is missing ORDER BY but has only TOP (did we have coverage for that case in the original change)?

---

Refers to: Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/PipelineFactory.cs:299 in 4d983f8. [](commit_id = 4d983f8, deletion_comment = False)

[Maya-Painter]

            Debug.Assert(queryInfo.Top.Value <= int.MaxValue, "PipelineFactory Assert!", "Top value must be <= int.MaxValue");

Do we need to repeat the original check here? What happens if query is missing ORDER BY but has only TOP (did we have coverage for that case in the original change)?

Refers to: Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/PipelineFactory.cs:299 in 4d983f8. [](commit_id = 4d983f8, deletion_comment = False)

With both SKIP + ORDER BY and just SKIP queryInfo.HasTop is set to false, so this assert is never hit.

[adityasa]

Consider adding coverage to NegativeQueryTests::TestTopOffsetLimitClientRanges for ORDER BY + OFFSET + LIMIT

---

In reply to: 2923582595

[adityasa]

[adityasa]