Skip to content

[Internal] Thin Client Integration: Fixes rntbd headers for proxy request.#5119

Merged
kirankumarkolli merged 7 commits intomasterfrom
users/aavasthy/bugfix_rntbdheaders
Apr 16, 2025
Merged

[Internal] Thin Client Integration: Fixes rntbd headers for proxy request.#5119
kirankumarkolli merged 7 commits intomasterfrom
users/aavasthy/bugfix_rntbdheaders

Conversation

@aavasthy
Copy link
Copy Markdown
Contributor

Pull Request Template

Description

Update the logic for retrieving and setting RNTBD headers resourceId and collectionRid for proxy request. With the current implementation the request ends up throwing a 400 Bad Request error.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue: closes #5118

Comment thread Microsoft.Azure.Cosmos/src/Routing/GlobalEndpointManager.cs
Copy link
Copy Markdown
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Microsoft.Azure.Cosmos/src/Resource/Settings/ContainerProperties.cs Outdated
Copy link
Copy Markdown
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Now.

@kundadebdatta kundadebdatta added auto-merge Enables automation to merge PRs thin-client-integration labels Apr 15, 2025
Copy link
Copy Markdown
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kundadebdatta kundadebdatta removed the auto-merge Enables automation to merge PRs label Apr 15, 2025
@aavasthy aavasthy added auto-merge Enables automation to merge PRs and removed DO NOT MERGE labels Apr 16, 2025
@aavasthy
Copy link
Copy Markdown
Contributor Author

Tested it end to end against stage endpoint.

@kirankumarkolli kirankumarkolli merged commit e1ee560 into master Apr 16, 2025
26 checks passed
@kirankumarkolli kirankumarkolli deleted the users/aavasthy/bugfix_rntbdheaders branch April 16, 2025 20:18
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure Cosmos SDKs Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enables automation to merge PRs thin-client-integration

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Internal] Thin Client Integration: Fix rntbd headers for proxy request.

4 participants