[Internal] Thin Client Integration: Fixes config refresh and gateway mode check.#5115
Merged
kirankumarkolli merged 2 commits intomasterfrom Apr 9, 2025
Merged
Conversation
aavasthy
requested review from
FabianMeiswinkel,
Pilchie,
kirankumarkolli and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aavasthy
changed the title
aavasthy
added
auto-merge
kundadebdatta
approved these changes
Apr 8, 2025
kirankumarkolli
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fixing two issues found during testing:
Fixing the issue of getting thinclient readable and writeable locations through
ParseThinClientLocationsFromAdditionalProperties. Need this call atGlobalEndpointManager.InitializeAccountPropertiesAndStartBackgroundRefresh()stage as well otherwise the returned endpoint returned is a stale value.Fixing the thinclient mode check so that if thinclient flag is enabled then thinclient mode is be used during gateway mode and direct mode.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #5116