Skip to content

[Internal] Open Telemetry: Fixes Metric Name and Unit changes#5098

Merged
kirankumarkolli merged 5 commits intomasterfrom
users/sourabhjain/otelunitnamechanges
Apr 2, 2025
Merged

[Internal] Open Telemetry: Fixes Metric Name and Unit changes#5098
kirankumarkolli merged 5 commits intomasterfrom
users/sourabhjain/otelunitnamechanges

Conversation

@sourabh1007
Copy link
Copy Markdown
Contributor

@sourabh1007 sourabh1007 commented Mar 28, 2025

Description

Changes in Metric and Unit Names

Metric Name (Old) Metric Name (New) Otel Official Link
db.client.response.row_count db.client.response.returned_rows https://opentelemetry.io/docs/specs/semconv/database/cosmosdb/#metric-dbclientresponsereturned_rows
Metric Name Old Unit New Unit Otel Official Link
db.client.response.returned_rows # {item} https://opentelemetry.io/docs/specs/semconv/database/database-metrics/#metric-dbclientresponsereturned_rows
azure.cosmosdb.client.active_instance.count # {instance} https://opentelemetry.io/docs/specs/semconv/database/cosmosdb/#metric-azurecosmosdbclientactive_instancecount
db.client.response.request_unit # RU {request_unit} https://opentelemetry.io/docs/specs/semconv/database/cosmosdb/#metric-azurecosmosdbclientoperationrequest_charge

Since, this feature is under preview, Hence, not following versioning for this.

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue: closes #5066

@sourabh1007 sourabh1007 requested a review from a team as a code owner March 30, 2025 18:13
Copy link
Copy Markdown
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sourabh1007 sourabh1007 added the auto-merge Enables automation to merge PRs label Apr 1, 2025
@sourabh1007 sourabh1007 self-assigned this Apr 1, 2025
@kirankumarkolli kirankumarkolli merged commit 402f9aa into master Apr 2, 2025
26 checks passed
@kirankumarkolli kirankumarkolli deleted the users/sourabhjain/otelunitnamechanges branch April 2, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enables automation to merge PRs

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Metrics units contain non-standard characters

4 participants