Skip to content

[Internal] PPAF: Adds Partition Level Failover for Gateway Mode#5087

Merged
kirankumarkolli merged 10 commits intomasterfrom
users/kundadebdatta/4982_support_ppaf_for_gateway_mode
Apr 2, 2025
Merged

[Internal] PPAF: Adds Partition Level Failover for Gateway Mode#5087
kirankumarkolli merged 10 commits intomasterfrom
users/kundadebdatta/4982_support_ppaf_for_gateway_mode

Conversation

@kundadebdatta
Copy link
Copy Markdown
Member

@kundadebdatta kundadebdatta commented Mar 24, 2025

Pull Request Template

Description

This PR introduces the partition level failover (PPAF + PPCB) for Gateway Mode. The changes are mainly done in the GatewayStoreModel which leverages the GlobalPartitionEndpointManager to apply the partition level override.

Since the gateway mode data plane requests are retried through the ClientRetryPolicy, the inbuild logic for the Direct mode suffices the need for triggering the partition level fail over on certain error codes.

As a part of the changes, we also introduced a new timeout policy HttpTimeoutPolicyForPartitionFailover to fail fast the gateway requests.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Closing issues

To automatically close an issue: closes #4982

@kundadebdatta kundadebdatta marked this pull request as ready for review April 1, 2025 00:02
@kundadebdatta kundadebdatta added the auto-merge Enables automation to merge PRs label Apr 1, 2025
Comment thread Microsoft.Azure.Cosmos/src/GatewayStoreModel.cs
Copy link
Copy Markdown
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks

Copy link
Copy Markdown
Contributor

@NaluTripician NaluTripician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kundadebdatta kundadebdatta added auto-merge Enables automation to merge PRs and removed auto-merge Enables automation to merge PRs labels Apr 1, 2025
@kirankumarkolli kirankumarkolli merged commit 8f59e24 into master Apr 2, 2025
26 checks passed
@kirankumarkolli kirankumarkolli deleted the users/kundadebdatta/4982_support_ppaf_for_gateway_mode branch April 2, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enables automation to merge PRs PerPartitionAutomaticFailover

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Per Partition Automatic Failover] - Add Gateway Support

4 participants