[Internal] Gates: Fixes bug where CosmosOperaitonCancellationException is now thrown in CancellationTokenTests#5076
Merged
kirankumarkolli merged 24 commits intomasterfrom Jun 20, 2025
Conversation
NaluTripician
requested review from
FabianMeiswinkel,
Pilchie,
kirankumarkolli and
sboshra
as code owners
Contributor
Author
|
This change will actually be covered in: #5063 |
1 task
kirankumarkolli
previously approved these changes
Mar 28, 2025
NaluTripician
requested review from
adityasa,
khdang,
kirillg and
neildsh
as code owners
Updated test to take out runtime differences in diagnostics to where OperationExceptionException occurs
kirankumarkolli
approved these changes
Jun 19, 2025
aavasthy
approved these changes
Jun 19, 2025
kirankumarkolli
deleted the
users/nalutripician/gatesCancellationTokenFix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
In our pipelines, the most common flaky test is related to the
CosmosOperationCanceledExceptionTestsclass. Here, about 50% of the time, an OperationCancelledException is thrown when the correct exception isCosmosOperationCanceledException. This PR makes sure that the correct exception is thrown in theAbstractRetryHandlerclass where the exceptions originate from.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #5208