Skip to content

Conversation

@sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Feb 4, 2025

Pull Request Template

Description

For Open Telemetry, we got new semantic conventions from Otel Community to follow.

Hence, as part of this PR, making changes accordingly.

  1. Changing prefix from db.client.cosmosdb to azure.cosmosdb.client (for attributes and metrics)
  2. db.system => db.system.name
  3. db.cosmosdb.client_id => azure.cosmosdb.client.id
  4. db.cosmosdb.connection_mode => azure.cosmosdb.connection.mode
  5. db.cosmosdb.request_content_length => azure.cosmosdb.request.body.size
  6. db.cosmosdb.response_content_length => azure.cosmosdb.response.body.size
  7. db.cosmosdb.regions_contacted=> azure.cosmosdb.contacted_regions
  8. db.cosmosdb.row_count => azure.cosmosdb.row.count
  9. db.cosmosdb.consistency_level => azure.cosmosdb.consistency.level

Type of change

  • [] New feature (non-breaking change which adds functionality)

@sourabh1007 sourabh1007 marked this pull request as ready for review February 5, 2025 01:43
Copy link
Contributor

@NaluTripician NaluTripician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the PR description explaining why the semantic changes need to happen for others looking at this PR in the future. Other than that, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enables automation to merge PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants